Fix lightproptime for cases when there is no SPEC TDC#867
Fix lightproptime for cases when there is no SPEC TDC#867nathanielerowe merged 4 commits intodevelopfrom
Conversation
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_12_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_12_02 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
Approved |
Description
When there is no SPECTDC products on the event the light propagation module does not put any
sbn::CorrectedOpFlashTimingobject on the event, which causes an error. This PR fixes the issue by replacing the return statement with a continue statement.It does also fix a minor bug found when running pds-only reconstruction. Waveform alignment module was not correctly configured in this case.
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?