Skip to content

Fix lightproptime for cases when there is no SPEC TDC#867

Merged
nathanielerowe merged 4 commits intodevelopfrom
bugfix/acastill_lightproptime
Nov 19, 2025
Merged

Fix lightproptime for cases when there is no SPEC TDC#867
nathanielerowe merged 4 commits intodevelopfrom
bugfix/acastill_lightproptime

Conversation

@asanchezcastillo
Copy link
Copy Markdown
Contributor

@asanchezcastillo asanchezcastillo commented Nov 7, 2025

Description

When there is no SPECTDC products on the event the light propagation module does not put any sbn::CorrectedOpFlashTiming object on the event, which causes an error. This PR fixes the issue by replacing the return statement with a continue statement.

It does also fix a minor bug found when running pds-only reconstruction. Waveform alignment module was not correctly configured in this case.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

@asanchezcastillo asanchezcastillo added the bug Something isn't working label Nov 7, 2025
@asanchezcastillo asanchezcastillo self-assigned this Nov 7, 2025
@linyan-w linyan-w moved this to Waiting on Reviewer in SBND 2025 Fall Production Nov 10, 2025
@linyan-w linyan-w moved this from Waiting on Reviewer to Reviewer Approved in SBND 2025 Fall Production Nov 17, 2025
@nathanielerowe
Copy link
Copy Markdown
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_12_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_12_02

@FNALbuild
Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Copy Markdown
Contributor

Approved

@nathanielerowe nathanielerowe moved this from Reviewer Approved to RM Approved in SBND 2025 Fall Production Nov 18, 2025
@nathanielerowe nathanielerowe merged commit 417030d into develop Nov 19, 2025
@nathanielerowe nathanielerowe moved this from RM Approved to In tagged release in SBND 2025 Fall Production Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: In tagged release

Development

Successfully merging this pull request may close these issues.

5 participants