Feature/acastill realistic pmt mc #876

asanchezcastillo · 2025-11-19T11:41:53Z

Description

This PR aims at providing a realistic PMT MC simulation at the detsim stage. In particular it modifies the following items:

PMT response simulation: with this PR the response of each PMT is simulated independently using a SER retrieved from the calibration database.
PMT noise simulation: with this PR the simulated noise for each PMT is randomly sampled from a file containing 1000 noise templates for each PMT.
PMT Gain Fluctuation: this PR introduces a new tool PMTGaussianGainFluctuation_tool.cc that allows simulating a different gaussian gain fluctuation for each PMT.
PMT Non-linearities: this PR introduces a new tool PMTNonLinearityTF1ChannelByChannel_tool.cc that allows simulating pmt non-linearity on a channel by channel basis.
PMT Pulse Oscillation: this PR introduces a new module PMTPulseOscillation_module.cc that reproduces the low-frequency oscillations that have been observed after large-amplitude signals. More information here ().
PMT Detection Efficiency: this PR modifies the PMT detection efficiencies to improve the data/MC agreement.

This PR does all the mentioned changes to the standard simulation workflow. It does also refactor the PMT-related fcl configuration files so there is only one single configuration file that contains ideal MC, realistic MC and data configurations.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{red}\bf{\textrm{IMPORTANT UPDATE June 22nd 2025:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production (which started in Spring 2025), you must make two PRs: one for develop and one for the production/v10_06_00 branch.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

Added at least 1 label from available labels.
Assigned at least 1 reviewer under Reviewers,
Assigned all contributers including yourself under Assignees
Linked any relevant issues under Developement
Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
Does this affect the standard workflow?
Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
This PR requires merging
#863
SBNSoftware/sbnd_data#4

Link(s) to docdb describing changes (optional)

Most of the changes are described here https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=43468

This reverts commit 05846ef.

…ctoring

lynnt20 · 2025-11-21T14:06:54Z

Yeah agreed, I'd like to wait to change the input label to avoid any conflicts, and we can put in a patch for final version. I don't think the pulse oscillation will have a meaningful impact on the validation II sample (for the software trigger) since we'll primarily be concerned with agreement for low energies, not high.

fjnicolas · 2025-11-20T23:46:24Z

sbndcode/OpDetSim/DigiPMTSBNDAlg.hh

+    void AddOscillationAfterPulse( std::vector<double>& wave);
+


The oscillation is being handled by a different module right? I think this function is unused.

Suggested change

void AddOscillationAfterPulse( std::vector<double>& wave);

fjnicolas · 2025-11-20T23:46:40Z

sbndcode/OpDetSim/DigiPMTSBNDAlg.hh

      fhicl::ParameterSet GainFluctuationsParams;
      bool SimulateNonLinearity; //Fluctuate PMT gain
+      bool PositivePolarity;
+      bool OscillateAfterPulse;


also unused

Suggested change

bool OscillateAfterPulse;

fjnicolas · 2025-11-20T23:49:17Z

sbndcode/OpDetSim/DigiPMTSBNDAlg.hh

      bool MakeGainFluctuations; //Fluctuate PMT gain
      fhicl::ParameterSet GainFluctuationsParams;
      bool SimulateNonLinearity; //Fluctuate PMT gain
+      bool PositivePolarity;


Unused? The waveform polarity is directly inferred from the SER in this line

Suggested change

bool PositivePolarity;

sbndcode/OpDetSim/DigiPMTSBNDAlg.hh

fjnicolas · 2025-11-21T00:02:08Z

sbndcode/OpDetReco/OpDeconvolution/job/sbnd_flashfinder_deco.fcl

Gazing at SBNDDecoSimpleFlashTPC0_data and SBNDDecoSimpleFlashTPC0_realisticMC, the parameters look completely identical.

Can we define a common table from which both _data and _realisticMC inherit?

ohh, I just saw you did it for the OpHit configuration, can we follow the same implementation here?

fjnicolas · 2025-11-21T00:03:42Z

sbndcode/OpDetReco/OpDeconvolution/job/opdeconvolution_sbnd.fcl

same here, just define a common table to avoid duplication and possible mis-configurations in the future

fjnicolas · 2025-11-21T00:55:51Z

sbndcode/OpDetSim/PMTPulseOscillations/job/sbnd_pmtpulseoscillation_config.fcl

can you add units for the configuration parameters (frequencies and OscillationThreshold) for easier future reference?

nathanielerowe · 2025-11-21T16:27:58Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_14_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_00

FNALbuild · 2025-11-21T16:42:02Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-11-21T16:43:41Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-11-21T16:54:07Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-11-21T16:56:48Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

nathanielerowe · 2025-11-21T17:01:46Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_14_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_00

FNALbuild · 2025-11-21T17:16:43Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-11-21T17:18:30Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-11-21T17:26:04Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-11-21T17:41:32Z

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

asanchezcastillo added 12 commits November 6, 2025 01:35

Implement data-based gaussian gain fluctuations

9e2397d

Add channel-by-channel non linearity

1ae5c2a

Add SER, gain fluct and nonlinearity per channel

5cb7650

Fix TF1 memory leak

f3d8bee

Add intialization method for using calibration database

e606f65

Add configuration function for old version

2111593

Call configuration function before using the tool

67cabff

Declare configure method on base class

b5ada10

Remove non linearity parameters from fcl

8e0354c

Update database configuration

05846ef

Add PMT pulse oscillation module

fd7926d

Modify MC workflow for realistic PDS

bbadc03

asanchezcastillo requested review from fjnicolas and linyan-w November 19, 2025 11:41

asanchezcastillo self-assigned this Nov 19, 2025

asanchezcastillo added the detsim Detector simulation label Nov 19, 2025

Fix random number generator

ef09336

asanchezcastillo requested a review from lynnt20 November 19, 2025 14:12

Revert "Update database configuration"

3f7d0ab

This reverts commit 05846ef.

linyan-w added this to SBND 2025 Fall Production Nov 19, 2025

linyan-w moved this to Expected for validation II in SBND 2025 Fall Production Nov 19, 2025

asanchezcastillo added 8 commits November 19, 2025 12:33

Modify HDOpticalWaveform configuration for data time sampling

943695f

Remove polarity as fcl-configurable parameter

21d8191

Remove polarity as fcl-configurable parameter

d326923

Fix noise baseline and cleanup

8c3b391

Update default configuration

7215509

Remove cout

caf4bbd

Modify standard config to include realistic PMT MC and major fcl refa…

f5b2fc9

…ctoring

Fix conflicts

0a34ac5

asanchezcastillo marked this pull request as ready for review November 19, 2025 19:22

asanchezcastillo added 4 commits November 21, 2025 06:04

Remove CRT includes

d05f478

Treat correctly the on/off calibrated/uncalibrated PMTs

6db4328

Change PMT detection efficiencies

5471469

Translate comments on the code

4a6aeb5

nathanielerowe moved this from Expected for validation II MC to Waiting on Reviewer in SBND 2025 Fall Production Nov 21, 2025

fjnicolas approved these changes Nov 21, 2025

View reviewed changes

nathanielerowe moved this from Waiting on Reviewer to Reviewer Approved in SBND 2025 Fall Production Nov 21, 2025

Merge branch 'develop' into feature/acastill_realistic_pmt_mc

f976ada

Merge branch 'develop' into feature/acastill_realistic_pmt_mc

6f37ad7

asanchezcastillo and others added 3 commits November 21, 2025 12:32

Add PMTPulseOscillation subdir

ed1d23d

Merge branch 'develop' into feature/acastill_realistic_pmt_mc

e62bbe5

Fix path within sbnd_data

dc4ef3e

nathanielerowe merged commit 5616ef6 into develop Nov 22, 2025

nathanielerowe moved this from Reviewer Approved to RM Approved in SBND 2025 Fall Production Nov 22, 2025

nathanielerowe moved this from RM Approved to In tagged release in SBND 2025 Fall Production Nov 22, 2025

This was referenced Nov 24, 2025

Realistic PDS MC simulation #774

Closed

Bugifx/acastill realistic pmt #886

Merged

asanchezcastillo deleted the feature/acastill_realistic_pmt_mc branch December 11, 2025 20:27

lynnt20 mentioned this pull request Dec 17, 2025

Bugifx/acastill realistic pmt #891

Merged

7 tasks

Feature/acastill realistic pmt mc #876

Feature/acastill realistic pmt mc #876

Uh oh!

Conversation

asanchezcastillo commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Relevant PR links (optional)

Link(s) to docdb describing changes (optional)

Uh oh!

lynnt20 commented Nov 21, 2025

Uh oh!

fjnicolas Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

fjnicolas Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

fjnicolas Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fjnicolas Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

fjnicolas Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

fjnicolas Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

fjnicolas Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

nathanielerowe commented Nov 21, 2025

Uh oh!

FNALbuild commented Nov 21, 2025

Uh oh!

FNALbuild commented Nov 21, 2025

Uh oh!

FNALbuild commented Nov 21, 2025

Uh oh!

FNALbuild commented Nov 21, 2025

Uh oh!

nathanielerowe commented Nov 21, 2025

Uh oh!

FNALbuild commented Nov 21, 2025

Uh oh!

FNALbuild commented Nov 21, 2025

Uh oh!

FNALbuild commented Nov 21, 2025

Uh oh!

FNALbuild commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

asanchezcastillo commented Nov 19, 2025 •

edited

Loading