-
Notifications
You must be signed in to change notification settings - Fork 54
Adding missing library link #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding missing library link #880
Conversation
|
Summoning @nathanielerowe as SBND RM but looks good to me! Thanks Gianluca :) |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_12_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_12_02 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
Approved |
|
The tests are being triggered in jenkins. |
|
+LArSoft tests OK on slf7 for c14:prof |
|
The tests are being triggered in jenkins. |
|
+LArSoft tests OK on slf7 for c14:prof |
|
+LArSoft tests OK on slf7 for e26:prof |
|
-uBooNE tests failed on slf7 for e26:prof |
|
-SBND tests warning, with build warning,, with ignored warning for build, on slf7 for e26:prof |
|
-ICARUS tests failed, with build warning,, with ignored warning for build, on slf7 for e26:prof |
|
-DUNE tests failed on slf7 for e26:prof |
A library is missing from the link list of one module.
This one was busted by the changes in LArSoft/lardataobj#54: RecoBase used to implicitly provide
ROOT::Hist, after that change it will not.This request is maintenance aimed to
developand future releases with updated LArSoft.It can merged immediately.