Trigger Emulation Bug Fix and smaller updates

[npallat]

Description

Trigger Emulation Bug Fix includes:

• Bug fix: previously the MonPulse length was taken from the FIRST waveforms in the vector of OpDetWaveforms, but this length corresponded to an XArapuca waveform, which is not the same size. This is fixed to now take the length from the first PMT waveform. (this is the major fix!)
• Added check: added warnings to make sure we are only considering and slicing PMT waveforms
• Added a vector of the number of pairs above threshold to the event (could be added to the cafs later)
• Added a vector of the number of pairs above threshold to the PMT decoder output too
• Updated Baseline fcl parameter to Run 2 Baseline,

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{red}\bf{\textrm{IMPORTANT UPDATE June 22nd 2025:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production (which started in Spring 2025), you must make two PRs: one for develop and one for the production/v10_06_00 branch.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

• Added at least 1 label from available labels.
• Assigned at least 1 reviewer under Reviewers,
• Assigned all contributers including yourself under Assignees
• Linked any relevant issues under Developement
• Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
• Does this affect the standard workflow?
• Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!
  This affects the ongoing validation release.

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
It does not require merging with another PR. However, here is a link to the original PR including this work, for reference.

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?
Here is a relevant presentation about this to the Trigger Working Group meeting.

[fjnicolas]

Thanks @npallat for putting this in!

My request before this gets in is reverting back to use run 1 baseline, since currently all our processing is based on run 1.

I left some other suggestions that I think should get address before a full scale production, but given the time constraint for the validation II samples I'd rather getting this in by now. Any thoughts @nathanielerowe @linyan-w?

[fjnicolas]

Is the cout here really a warning? It is expected that the PMT_Channels vector is empty when you call it fom the PMTDecoder module.

[npallat]

The PMTDecoder has to assign the ReadoutSize differently because it is using data not MC:

          int NumFlash = fWaveforms.size() / (fTotalCAENBoards * PMTPerBoard);
          int FirstReadoutIndex = 0 + FlashCounter*PMTPerBoard + 0*PMTPerBoard*NumFlash;
          int ReadoutSize = fWaveforms[FirstReadoutIndex].size();

I could change this to just assign the ReadoutSize as ReadoutSize = fWaveforms[Pair1[0]].size() though since a warning will appear later when we loop through the channels if PMT_Channels is empty.

[fjnicolas]

thanks for the catch @asanchezcastillo! my suggestion then is:

• changing the baseline in digi_pmt_sbnd.fcl to use 14250 ADC (as in run 1 data)
• TriggerEmulation inherits the baseline value from the PMT fhicl

Otherwise we'd need to have two configurations for the TriggerEmulation service, one for data, one for MC.

[fjnicolas]

Thank you so much Nikki! Ready for CI!

[nathanielerowe]

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_14_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_00

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[nathanielerowe]

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_14_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_00

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[nathanielerowe]

Approved