Conversation
henrylay97
added
crt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I am starting to put together slides and PRs to preserve work of mine that lives offline before I leave.
The CRT ADC saturates at a value of 4089 in data, compared to the 4095 we have been simulating. This PR changes that default value and also ensures that the mechanism to label a saturated channel in the CRTStripHit reconstruction is resilient to this change, and that the pedestal subtraction doesn't impact that.
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Accompanying PR: SBNSoftware/sbnobj#168
Link(s) to docdb describing changes (optional)
It is documented in slides: https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=45697