Conversation
Only comes with deprecation warnings...
Also contains a fix for the aggregation failure test (just re-enabling the test by defining DEBUG_AGGREGATION_CALLS within the test itself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the entire interface and file hierarchy to consistently use the cppuddle namespace. It further breaks the functionality into three sub-namespaces: memory_recycling (for the buffer management and the allocators), executor_recycling (for the executor pools and executor RAII wrapper) and kernel_aggregation (for the executors/allocators that enable the on-the-fly kernel aggregation/kernel fusion).
The old interface (and header files) should still work, but is deprecated from now on (and will consequently cause quite a lot of warnings).