Cleanup Constraints, added comments, docs, and a roadmap#2085
Merged
akenmorris merged 18 commits intomasterfrom Jul 15, 2023
Merged
Cleanup Constraints, added comments, docs, and a roadmap#2085akenmorris merged 18 commits intomasterfrom
akenmorris merged 18 commits intomasterfrom
Conversation
…rajectory calculations to apply constraints.
…. This was once projected to replace the snap to surface ApplyConstraints routine. In hindsight, it would have worked much better if we had used a lambda for each particles instead of each domain. However, the Newton update still yields more stable results so I'm removing it.
akenmorris
reviewed
Jun 2, 2023
Contributor
There was a problem hiding this comment.
Accidentally committed? We still need to fix this issue about test files being modified.
Contributor
Author
There was a problem hiding this comment.
Yeah, should we just remove this file from tracking?
Contributor
There was a problem hiding this comment.
Unfortunately, it's needed. Otherwise the fixed domain test fails.
…/ShapeWorks into cleanup_constraints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a roadmap to navigate all the constraints code, additional comments in Doxygen-friendly format, a constraint group in the docs, and removed a ton of dead or useless code.
The only confusing parts are that we still have the constraint reads for both json and xml in the code, and the snap-to-surface routine still has the confusing name "ApplyConstraints".
Given the roadmap in "Libs/Optimize/Constraints/Constraints.cpp", I hope newer developers can edit and understand the constraints code better and can modify it more easily.
IMPORTANT: Completely removed SphereConstraints.