Merged
Conversation
Two unrelated Mac install/build fixes bundled: - Replace bare `pip` with `python -m pip` in install_shapeworks.sh and Installation/install_python_module.sh. On Intel Macs with Homebrew, `/usr/local/bin/pip` can shadow the conda env pip even when python resolves correctly, causing package installs (numpy<2, open3d, shapeworks Python packages) to land in the wrong interpreter and install_python_module.sh to fail with a bad shebang before it could substitute the shapeworks_py path. - Add MACOSX_DEPLOYMENT_TARGET=12.0 to both Mac workflows and the cmake invocation, and fold the target into the deps cache key to force a rebuild of cached deps. Without a pin, binaries built on macos-15 runners required macOS 15+ at dlopen (missing newer libc++ symbols like std::exception_ptr::__from_native_exception_pointer), breaking ShapeWorks on anything older than Sequoia.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to 6.8.0-dev for master.