Closed
Conversation
Member
|
Please add support for embeds using config elements |
SCDerox
requested changes
May 29, 2022
SCDerox
requested changes
May 30, 2022
SCDerox
requested changes
May 30, 2022
Member
SCDerox
left a comment
SCDerox
left a comment
There was a problem hiding this comment.
Sorry, but this does not work at all - several issues such as comparing objects with IDs, wrong looping and others need to be addressed...
I will fix these issues (I spent way too much time trying to give you feedback, but at this point it's easier to do it myself completely, sorry).
You can find a ZIP of the working version attached.
auto-react.zip
Contributor
Author
|
I shouldn't do anyting while I'm tired |
Member
|
No worries, I know this too well, if I am tired I can't do anything right ^^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by shini in https://features.sc-network.net/board/custombot/412 I added a reply-to-mention feature in the auto-react-module. Something went wrong with my Webstorm branches again, so the commits are made directly on the GitHub website, pasted from webstorm