Test Function Pointer #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/pmpo_defines.h src/pmpo_materialPoints.cpp test/CMakeLists.txt
onkarsahni
requested changes
Jan 18, 2024
onkarsahni
left a comment
onkarsahni
left a comment
There was a problem hiding this comment.
Sorry took long to get to this.
Changes look good.
A few more minor changes requested (in testMPAppIDs.cpp).
Thanks.
onkarsahni
reviewed
Jan 19, 2024
onkarsahni
left a comment
onkarsahni
left a comment
There was a problem hiding this comment.
One more comment on my previous review.
Angelyr
commented
Jan 23, 2024
onkarsahni
requested changes
Jan 24, 2024
onkarsahni
left a comment
onkarsahni
left a comment
There was a problem hiding this comment.
Looks good. A few more minor items.
onkarsahni
approved these changes
Jan 25, 2024
|
Looks good. Merged and deleted the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pointer to external MPAppIDs
Added test for setting external MPAppID pointer
Fixed bug with updateMaxAppID