Coverage is missing coverage reports from test tmp dirs #3048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mp test dirs, so this change makes sure those data files get included in the report.
bdbaddog
reviewed
Jan 17, 2018
test/Repository/M4.py
Outdated
| test = TestSCons.TestSCons() | ||
|
|
||
| # TODO: figure out how to write the coverage data to the locked folder or maybe somewhere else | ||
| if 'COVERAGE_PROCESS_START' in os.environ: |
Contributor
There was a problem hiding this comment.
Can you move the test for running under coverage to QMTest/TestSCons.py such that you can use : if test.coverage_run(): Just to simplify any changes going forward?
Contributor
|
Thanks for re-submitting the pull request with updates post bug migration snafu. |
Contributor
Author
|
I moved the skipping of that test from the travis.yml to the test itself,
where it checks for the coverage environment variable, to make travis.yml
more agnostic
…On Tue, Jan 16, 2018 at 10:15 PM, William Deegan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .travis.yml
<#3048 (comment)>:
> # Not including this workaround in the coverage report, because it will result
# in constantly changing coverage reports depending on the number of times
# the JobTests.py had to run to pass
# TODO: figure out how to cover JobTests.py
# - n=0; while [[ $n -lt 10 ]]; do coverage run --rcfile=$PWD/.coveragerc runtest.py src/engine/SCons/JobTests.py && break; n=$((n+1)); done; if [ "$n" -gt "9" ]; then false; fi
# exclude JobTest.py becuase we already ran that
- echo "src/engine/SCons/JobTests.py" > exclude_jobtest
- # also exclude this test since it overides the exit function which doesnt work with coverage
- # more info here: https://coverage.readthedocs.io/en/coverage-4.4.2/subprocess.html#
- # TODO: figure out how to cover test/exitfns.py
- - echo "test/exitfns.py" >> exclude_jobtest
Is this test no longer an issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3048 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AF2YzGD5Ycxi0OqOCTEfttQe5vaDvmsNks5tLWXUgaJpZM4RgoJZ>
.
|
Contributor
|
Looks good. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the use of the COVERAGE_FILE environment variable so that coverage reports from test run in the tmp dir will be saved after those tmp dirs get deleted.
This is a resubmit of this PR: #36 that was never successfully added when the Github issues were attempted to be migrated from tigris.