Get a little smarter about finding the scons engine. #3218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the common script stanza, Previous version was generating some paths that were not useful. Make sure the path pulled from package info is not mangled into unsuability. General cleanup. Write error message to stderr instead of stdout in scons.py. Signed-off-by: Mats Wichmann <mats@linux.com>
Contributor
|
Do these changes break the scons-local package? |
Collaborator
Author
shouldn't... the local directories are only dropped if they don't exist. but if they do, I'll fix it - I use scons-local in a project here so easy to test. |
Collaborator
Author
|
Working for me at least: |
Contributor
|
o.k merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the common script stanza, previous version was generating some paths
that were not useful. Make sure the path pulled from package info is
not mangled into unsuability. General cleanup.
Write error message to stderr instead of stdout in scons.py.
Signed-off-by: Mats Wichmann mats@linux.com
Remove this paragraph
Please have a look at our developer documentation before submitting your Pull Request.
http://scons.org/guidelines.html
Contributor Checklist:
master/src/CHANGES.txtdirectory (and read theREADME.txtin that directory)