Skip to content

Fix CPP PreProcess error that regex match "if" in "ifndef" #3237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ArdaFu wants to merge 0 commits into from
Closed

Fix CPP PreProcess error that regex match "if" in "ifndef" #3237

ArdaFu wants to merge 0 commits into from

Conversation

@ArdaFu
Copy link
Contributor

@ArdaFu ArdaFu commented Nov 7, 2018 •
edited
Loading

Fix the AttributeError: 'NoneType' object has no attribute 'groups' when using SCons with Python 3.7.1.

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated master/src/CHANGES.txt directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation

@ArdaFu ArdaFu mentioned this pull request Nov 7, 2018
Merged
@coveralls
Copy link

coveralls commented Nov 7, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 79.921% when pulling 138962d on ArdaFu:master into 6248b8d on SCons:master.

@bdbaddog
Copy link
Contributor

bdbaddog commented Nov 8, 2018

Can you create a test to exercise the bug?

@ArdaFu
Copy link
Contributor Author

ArdaFu commented Nov 12, 2018

After tracing the code. I found that the bug is cpp regex match "if" in "ifndef".

@ArdaFu
Copy link
Contributor Author

ArdaFu commented Nov 12, 2018

@bdbaddog New test case is added.

@ArdaFu ArdaFu changed the title Fix CPP Tupleize method get error when regex match is failed. Fix CPP PreProcess error that regex match "if" in "ifndef" Nov 12, 2018
@bdbaddog
Copy link
Contributor

bdbaddog commented Nov 12, 2018

Please rebase from main and push.
That should resolve the tests failing on windows.

bdbaddog
bdbaddog reviewed Nov 12, 2018
View reviewed changes
src/CHANGES.txt Outdated


From Arda Fu
- Fix cpp regex error that match 'if' in 'ifndef'.
Copy link
Contributor

@bdbaddog bdbaddog Nov 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to be "Fix cpp scanner regex logic to treat ifndef. Previously it was not properly differentiating between if, ifdef, and ifndef"
Assuming this is accurate and I'm understanding this change..

@ArdaFu ArdaFu closed this Nov 13, 2018
@ArdaFu ArdaFu mentioned this pull request Nov 13, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdbaddog bdbaddog bdbaddog left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ArdaFu @coveralls @bdbaddog