Switch stages around to get correct build failures from Travis CI#3282
Merged
Conversation
dmoody256
force-pushed
the
travis_doesnt_report_fails
branch
from
e2ce4d8 to
53d22ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow on patch to #3275, which fixes an issue where Travis will report a pass when one of the platform test runs could have failed.
Example here shows 3.6 failing, but since the last stage is Coverage and it passed, then the build reported pass:
https://travis-ci.org/SCons/scons/builds/486015577
This PR: