Skip to content

Issue #3283 fix md5 timestamp with config force second run exception#3284

Merged
bdbaddog merged 5 commits into
SCons:masterfrom
bdbaddog:gh_3283_fix_md5_timestamp_with_config_force_second_run_exception
Feb 2, 2019
Merged

Issue #3283 fix md5 timestamp with config force second run exception#3284
bdbaddog merged 5 commits into
SCons:masterfrom
bdbaddog:gh_3283_fix_md5_timestamp_with_config_force_second_run_exception

Conversation

@bdbaddog
Copy link
Copy Markdown
Contributor

Fix issue #3283

- Fix Issue #3283 - Handle using --config=force in combination with Decider('MD5-timestamp').
  3.0.2 in fix for issue #2980 added that deciders can throw DeciderNeedsNode exception.
  The Configure logic directly calls the decider when using --config=force but wasn't handling
  that exception.  This would yield minimally configure tests using TryLink() not running and
  leaving TypeError Nonetype exception in config.log

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated master/src/CHANGES.txt directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation

@bdbaddog bdbaddog added this to the 3.0.5 milestone Jan 30, 2019
@bdbaddog bdbaddog requested a review from garyo January 30, 2019 22:13
@bdbaddog bdbaddog changed the title Gh 3283 fix md5 timestamp with config force second run exception Issue #3283 fix md5 timestamp with config force second run exception Jan 30, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 1, 2019

Codecov Report

Merging #3284 into master will decrease coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3284      +/-   ##
==========================================
- Coverage   87.78%   87.76%   -0.02%     
==========================================
  Files         187      187              
  Lines       24290    24296       +6     
==========================================
+ Hits        21323    21324       +1     
- Misses       2967     2972       +5
Impacted Files Coverage Δ
src/engine/SCons/Job.py 93.88% <100%> (ø) ⬆️
src/engine/SCons/SConf.py 94.89% <71.42%> (-0.31%) ⬇️
src/engine/SCons/Util.py 80.62% <0%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e17391...2860462. Read the comment docs.

@bdbaddog bdbaddog force-pushed the gh_3283_fix_md5_timestamp_with_config_force_second_run_exception branch from f8c640f to 2860462 Compare February 2, 2019 18:22
@bdbaddog bdbaddog merged commit 2b1d78a into SCons:master Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant