[NINJA] Added option to allow scons to determine if it should skip ninja regeneration. #4169
Conversation
dmoody256
changed the title
| import SCons | ||
| import random | ||
| SetOption('experimental','ninja') | ||
| SetOption('skip_ninja_regen', True) |
There was a problem hiding this comment.
If I comment this line out, the test still passes? Is that expected?
There was a problem hiding this comment.
yeah actually this flag is not relevant to the current test. This PR makes ninja files deterministic, but the flag is for controlling skipping the regeneration and restarting of the daemon. The flag is to protect users who may be using Glob or SCons generated files in command lines. Its assumed if the user enables the flag, they know what they are doing.
I will update this test to also make sure the mtime of the ninja file did not change, which would indicate it was never overwritten.
There was a problem hiding this comment.
o.k. so run this test with master branch code and it should fail then?
There was a problem hiding this comment.
yeah I tested that in the latest
|
@bdbaddog fixed the notes, and updated the test |
…ixture sconstruct
2 participants
Contributor Checklist:
CHANGES.txt(and read theREADME.rst)