Make Exit(), GetLaunchDir() and SConscriptChdir() static#4234
Merged
Conversation
Exit(), GetLaunchDir() and SConscriptChdir()
Contributor
|
Doing this would require a deprecation cycle. |
Contributor
Author
|
For the private method that is not supposed to be exposed? |
Contributor
Removing those methods from Environment().. |
Contributor
Author
|
This PR doesn't remove them. Should it start the deprecation cycle now that the docs moved methods into global scope? |
Contributor
|
You are correct. My mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #4224 which is a consequence of #4223
EnsurePythonVersion(), Exit(), GetLaunchDir() and SConscriptChdir().
Contributor Checklist:
CHANGES.txt(and read theREADME.rst)