Fix debug include printing for multi-source#4799
Merged
bdbaddog merged 1 commit intoSCons:masterfrom Dec 14, 2025
Merged
Conversation
Rather obscure bug - if --debug=includes is selected, the analysis stopped after the first source file of a given target. For the common case of C/C++ projects, the object builders are single-source, so the problem would not be noticed. Signed-off-by: Mats Wichmann <mats@linux.com>
Collaborator
Author
|
Just so it's mentioned here, do the printouts make sense? For source file Why all the extra noise? |
Collaborator
Author
|
hmmm, wonder if this is due to the Fake scanner... may need to be a little bit more clever on that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather obscure bug - if
--debug=includesis selected, the analysis stopped after the first source file of a given target. For the common case of C/C++ projects, the object builders are single-source, so the problem would not be noticed.Adds a distinct testcase, because the main debug-includes test uses the C compiler, which won't trigger this.
No doc impacts, although the documentation of the option could perhaps be a little more explicit.
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).