Merged
Conversation
Counting frames to update Calendar is not reliable in case the display is turned off. When you turn off display at night and turn on in the morning, Calendar will be outdated until 800 frames since last update finish. Instead, use time-based approach. Querying SystemClock.uptimeMillis is much cheaper than recalculating Calendar fields on every frame.
Owner
|
I also added a forced calendar update on onResume earlier here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counting frames to update Calendar is not reliable in case the display is turned off. When you turn off display at night and turn on in the morning, Calendar will be outdated until 800 frames since last update finish.
Instead, use time-based approach. Querying SystemClock.uptimeMillis is much cheaper than recalculating Calendar fields on every frame.