Reformat code with default formatter#18
Merged
SCratORS merged 1 commit intoSCratORS:mainfrom Feb 10, 2024
Merged
Conversation
- reformat with default Android Studio formatter - organize imports - disable formatting for some parts of code - mark final classes and variables as final - reduce visibility to package-private where possible - use conventional naming pattern for constants - move render and setupPosition to base class to avoid class lookup No changes in logic or values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason is that usually I run automatic formatter after every change, and I get unrelated changes in diffs.
Also, I am working on increasing the frame rate by generating new frames, it would be nice if the frames are also formatted.
Changes:
No changes in logic or values.
Reason to use
finalmodifiers:Reason for reducing visibility scope (adding
privateand replacing withpackage-private):