Conversation
It is not necessary to add the variable "animCounterSkip", instead you can bind to the object's frame counter. And given the "Butterfly" animation there was no "animCounterSkip"
Contributor
|
I did not do texture skips for butterflies because they look better without skipping. I.e. when textures moving faster.
That's a good idea, I will remove it later. |
Owner
Author
|
it seemed to me that they look twitchy when changing textures quickly. the speed of the original seemed more attractive to me |
SCratORS
pushed a commit
that referenced
this pull request
Feb 12, 2024
1. When we increase FPS, the MAX_FRAMES variable is also incremented 2 times faster. It is mainly needed to control the speed of creating new animation objects. Therefore, its value must be increased by 2 times, otherwise there will be too many objects. 2. I also returned ForceUpdateCalendar when the screen is turned on, after all, it gives a result with frequent time changes (as an option during testing) 3. In some animations, I changed the way I skip texture changes. like in #30 P.S. While there are still questions with Fairy (there are complex animations), FireWork and Eye - 20 FPS (When switching to them from 40 FPS, they work faster than necessary for a while)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not necessary to add the variable "animCounterSkip", instead you can bind to the object's frame counter. And given the "Butterfly" animation there was no "animCounterSkip"