Skip to content

Remove dpToPixels#41

Merged
SCratORS merged 1 commit intoSCratORS:mainfrom
Doctoror:remove-dp-to-pixels
Feb 15, 2024
Merged

Remove dpToPixels#41
SCratORS merged 1 commit intoSCratORS:mainfrom
Doctoror:remove-dp-to-pixels

Conversation

@Doctoror
Copy link
Copy Markdown
Contributor

@Doctoror Doctoror commented Feb 15, 2024

dpToPixels needs to be removed.

Pixel 7 Pro. main (left) vs remove-dp-to-pixels (right)
  

Nexus S (480x800). main (left) vs remove-dp-to-pixels (right)
  

@Doctoror Doctoror mentioned this pull request Feb 15, 2024
@SCratORS
Copy link
Copy Markdown
Owner

I understood. Is there a new problem? If you go to the screen settings in the emulator and reduce the font size, then the graphics break. But if you set dipToPixel(1), then everything is restored. Otherwise, you are right. What should I do about it?
image

@Doctoror
Copy link
Copy Markdown
Contributor Author

I will try these settings and let you know

@Doctoror
Copy link
Copy Markdown
Contributor Author

These settings don't break the app on my branch for me, Nexus S 480x800

@SCratORS
Copy link
Copy Markdown
Owner

I was wrong. This is a problem in my emulator. I changed the DPI too often, it just glitched.

@SCratORS SCratORS merged commit 3fb31a6 into SCratORS:main Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants