Merged
Conversation
The RL pipeline is not working properly with the new refactor including: - Input/Output results - Config files
Collaborator
Author
|
Again, until we finalize all CLI entries should we worry about the Cross-platform pipeline? I think it should be the last step and then we check. But, I could be completely wrong. |
arashr88
approved these changes
Aug 12, 2025
arashr88
approved these changes
Aug 12, 2025
ryanmccann1024
added a commit
that referenced
this pull request
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR refactors the RL training pipeline to restore compatibility with the updated project structure and configuration system. Specifically:
train_pipeline.pyto correctly extract, format, and pass simulation configuration data to the RL environment.create_environment()to accept flat config dictionaries and wrap them as needed (e.g. in ans1key) forSimEnv.SimEnvexpectations while maintaining minimal surface area for potential breakage.TODOs in strategic places to revisit hardcoded assumptions in future refactors.These changes unblock usage of the
run_train.pyCLI entrypoint and allow proper training execution using--agent_type rlwith.ini-based configs.Fixes
Fixes: # (restore compatibility of RL pipeline post-refactor)
🧐 Type of Change
💥 Impact of Breaking Change
SimEnvstill expectssim_dictto include ans1key. This PR introduces a shim insidecreate_environment()to enforce that format.ConfigManager.from_args()and support.iniconfigs end-to-end.🧪 How Has This Been Tested?
All changes were tested by: