fix: property name standardization and comprehensive test fixes#120
Merged
ryanmccann1024 merged 7 commits intorelease/6.0.0from Sep 20, 2025
Merged
Conversation
Apply FUSION coding standards to spectrum_assignment.py following the established pattern of property name standardization and code quality improvements across the codebase. Key improvements: - Rename attributes for clarity: spec_help_obj → spectrum_helpers, snr_obj → snr_measurements, engine_props → engine_props_dict - Improve method names: _allocate_best_fit → _allocate_best_fit_spectrum, handle_first_last → handle_first_last_allocation, xt_aware → handle_crosstalk_aware_allocation, _get_spectrum → _determine_spectrum_allocation - Enhance variable naming: open_slots_arr → available_slots_array, core_num → core_number, src/dest → source_node/destination_node - Add proper type annotations and Sphinx-format docstrings - Move TODO for 7-core limitation to proper TODO.md file - Update corresponding unit tests to use new naming conventions - Maintain backward compatibility for public API methods This continues the codebase-wide effort to standardize naming conventions, improve code readability, and ensure consistent code quality across all core modules. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Correct mod_format_list to _mod_format_list parameter name in get_spectrum_dynamic_slicing method calls to match method signature. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Reorganize imports alphabetically and add missing type annotation for topology variable in factory.py. Module already followed most coding standards with excellent documentation and type hints. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add comprehensive type annotations, improve variable naming with descriptive suffixes, reorganize imports, and enhance docstrings to follow Sphinx format consistently. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Enhance variable naming with descriptive suffixes, improve type annotations, reorganize imports alphabetically, and standardize docstrings to consistent Sphinx format. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Standardize parameter names in method definition to match calling convention and improve documentation consistency. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…s-to-interfaces-io-reporting refactor: apply coding standards to interfaces, io, and reporting modules
arashr88
approved these changes
Sep 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements comprehensive property name standardization across the FUSION codebase and resolves numerous test failures. The changes include applying coding standards to core modules (interfaces, IO, reporting), standardizing property names throughout the system, fixing parameter mismatches, and updating method signatures for consistency. Additionally, extensive test fixes were implemented to ensure all tests pass with the new standardized naming conventions.
🔧 Type of Change
Primary Change Type:
Component(s) Affected:
fusion/cli/)fusion/configs/)fusion/core/)fusion/modules/rl/,fusion/modules/ml/)fusion/modules/routing/)fusion/modules/spectrum/)fusion/modules/snr/)fusion/visualization/)fusion/gui/)fusion/unity/)tests/).github/)🧪 Testing
Test Coverage:
Test Details:
Comprehensive test suite fixes were implemented to address failures caused by:
Test Configuration Used:
Commands to Reproduce Testing:
Test Results:
📊 Impact Analysis
Performance Impact:
Memory Usage:
Backward Compatibility:
Dependencies:
🔄 Migration Guide
Breaking Changes (if any):
Migration Steps:
Before/After Examples:
✅ Code Quality Checklist
Architecture & Design:
Code Standards:
Configuration & CLI:
Security:
📚 Documentation
Documentation Updates:
Examples Added:
🚀 Deployment
Deployment Considerations:
Manual Steps Required:
None - changes are primarily internal standardization and test fixes.
🔍 Review Guidelines
For Reviewers:
Review Focus Areas:
📝 Additional Notes
Major Changes Implemented:
Property Name Standardization: Applied consistent naming conventions across:
Coding Standards Application: Updated modules to follow project coding standards:
Test Infrastructure Fixes: Comprehensive test suite updates including:
Method Signature Updates:
Documentation Cleanup:
Commit Summary:
Testing Notes:
All tests now pass with the standardized property names and updated module structure. The changes maintain functionality while improving code consistency and maintainability.
Future Work:
Related PRs:
🏁 Final Checklist
Before submitting this PR, confirm: