Fix/survivability#142
Merged
ryanmccann1024 merged 7 commits intofeature/surv-v1-phase7-resultsfrom Nov 7, 2025
Merged
Conversation
- Rename .github/issue_template to ISSUE_TEMPLATE (GitHub canonical format) - Fix broken links in issue template config.yml (Architecture Plan, Publications) - Add comprehensive ARCHITECTURE.md with system design, components, and data flow - Enhance README Publications section with structured citation format - Remove GitHub Discussions link from issue resources - Add placeholder for community-contributed publications All issue template resource links now point to existing documentation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Modernize all GitHub issue templates, PR templates, and commit message guide by removing emojis from section headers and titles. This creates a more professional appearance appropriate for a research simulator while maintaining all functionality and structure. Files updated: - Issue templates (bug report, feature request, config) - PR templates (feature, hotfix, general) - Commit message guide 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Update config validation error message to be path-agnostic since users can pass config files from any location via command line, not just ini/run_ini/. Remove emojis from user-facing error messages in run_gui and run_train for cleaner output. Update TODO entries to clarify that GUI and multi-processing features need full implementation. Standardize docstring formatting across all CLI modules for consistency. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Corrected CLI invocation syntax throughout documentation by adding the missing 'run_sim' subcommand. The correct format is: `python -m fusion.cli.run_sim run_sim --config_path ...` Added comprehensive "Templates vs Examples" section to configs/README.md explaining the distinction between generic reusable templates and specific ready-to-run example configurations. Changes include: - Fix CLI command examples in cli/README.md and configs/examples/README.md - Add "Templates vs Examples" section with comparison table and usage guidance - Add TODO for YAML/JSON configuration file input support - Add TODO for single entry point CLI architecture (fusion run_sim) - Add TODO for schema system consolidation (schema.py vs schemas/*.json) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Remove emojis from all top-level markdown files for professional presentation while maintaining readability and structure. Documentation improvements: - Remove emojis from README.md and DEVELOPMENT_QUICKSTART.md - Add comprehensive CLAUDE.md with project context for AI assistants - Fix placeholder email in CODE_OF_CONDUCT.md enforcement section - Streamline CONTRIBUTING.md with references to detailed standards - Remove research planning files (new-paper-*.md) Code quality improvements: - Remove redundant default values in network_analysis.py - Fix docstring formatting in cli_to_config.py - Add ML support TODO item in core/TODO.md - Remove verbose seeding comment block in simulation.py
…ture Resolve configuration duplication issues by implementing a hybrid system that supports both nested sections and flat backward-compatible access patterns. Changes: - Update config loader to preserve non-general sections as nested dicts - Add mirroring function to copy nested values to root for backward compat - Move route_method and allocation_method from required to optional settings - Reorganize routing and spectrum parameters into dedicated sections - Add missing ml_settings parameters across all config files - Add missing failure_settings parameters to survivability examples This allows new code to access engine_props["routing_settings"]["k_paths"] while legacy code continues to work with engine_props["k_paths"]. All configuration files now have clean separation between general_settings and specialized sections (routing_settings, spectrum_settings, ml_settings). Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Fix test failures caused by recent routing architecture refactoring that introduced route_props for storing routing algorithm results. Also fix config tests to match hybrid nested/flat configuration architecture and remove emoji expectations per project guidelines. Changes include: - Add default values in network_analysis.get_link_usage_summary - Update factory tests to mock route_props.paths_matrix - Fix config_setup tests for nested optional options - Update CLI tests to remove emoji expectations (GUI and train) - Fix schema tests to match current required options structure - Complete route_props integration in routing algorithms Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
ryanmccann1024
merged commit e168663
into
feature/surv-v1-phase7-results
5 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick merge.