This repository was archived by the owner on Oct 6, 2025. It is now read-only.
66 task add the lights and gear subscriber to the qt app#68
Merged
Rui-Pedro-Pires merged 18 commits intodevfrom Jan 21, 2025
Merged
Conversation
…roperties into LightStatus struct
…memcpy calls to use as_string() for payload handling
…ht properties in LightStatus struct
…acing in SpeedDisplay
…d improve visibility handling
…nt directly; adjust include paths for InstrumentCluster
…atteryStatus type; update related methods and QML bindings
…use BatteryStatus struct and improve light status properties
…gear display and improve light visibility handling
…gration; update gear handling in InstrumentCluster and related QML bindings
Rui-Pedro-Pires
deleted the
66-task-add-the-lights-and-gear-subscriber-to-the-qt-app
branch
Rui-Pedro-Pires
added a commit
that referenced
this pull request
Aug 5, 2025
…subscriber-to-the-qt-app 66 task add the lights and gear subscriber to the qt app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Description
This pull request includes several changes to the
InstrumentClusterapplication, focusing on refactoring the codebase, updating theInstrumentClusterclass, and modifying related files to improve functionality and maintainability.Refactoring and code improvements:
src/InstrumentCluster.cpp: Refactored theInstrumentClusterconstructor to initialize subscribers for speed, battery, lights, and gear, and updated theSessionobject initialization.include/InstrumentCluster.hpp: Introduced newLightStatus,BatteryStatus, andGearPositionstructs, and updated theInstrumentClusterclass to use these structs for properties and signals.src/main.cpp: Simplified the main function by removing individual signal handlers and delegating the responsibilities to theInstrumentClusterclass.Submodule and build system updates:
.gitmodules: Removed theMiddleWare/Libssubmodule.CMakeLists.txt: Updated the executable target name fromInstrumentClustertoInstrumentClusterAppand included theincludedirectory.Functional changes:
MiddleWare/src/main.cpp: Updated the battery calculation logic to use a double for more accurate percentage representation and clamping the value between 0 and 100.UI updates:
ui/GearShiftInfo.qml: Updated the gear shift indicator to dynamically change colors based on the current gear position.These changes collectively enhance the structure, readability, and functionality of the
InstrumentClusterapplication.Type of Change
Checklist
Related Issues
Additional Context
Reviewer Checklist