Skip to content

v1.8.0#23

Merged
ls-michielrensen merged 18 commits intomasterfrom
v1.8.0
Dec 6, 2016
Merged

v1.8.0#23
ls-michielrensen merged 18 commits intomasterfrom
v1.8.0

Conversation

@ls-michielrensen
Copy link
Copy Markdown
Contributor

@ls-michielrensen ls-michielrensen commented Nov 23, 2016

@ls-michielrensen ls-michielrensen changed the title V1.8.0 v1.8.0 Nov 23, 2016
Comment thread README.md Outdated
{
"require": {
"seoshop/seoshop-php": "~1.7"
"seoshop/seoshop-php": "^1.8"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know that in this case the tilde and the caret are the same? Only when doing ~1.8.0 it would be >=1.8.0,<1.9.0, with ~1.8 it would be >=1.8.0,<2.0.0, just like the caret.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I mixed up the two, tilde is fine here :)

Comment thread composer.json Outdated
"homepage": "http://developers.seoshop.com",
"description": "PHP client for the Lightspeed eCom API",
"keywords": ["api", "client", "php", "ecom", "lightspeed"],
"homepage": "http://http://developers.lightspeedhq.com/ecom",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

@ls-michielrensen ls-michielrensen merged commit a6a71aa into master Dec 6, 2016
@ls-michielrensen ls-michielrensen deleted the v1.8.0 branch December 6, 2016 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants