This repository was archived by the owner on Jun 23, 2023. It is now read-only.
New commands parser implications. #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the calls to General.SplitString() in order to have a consistent and reliable commands parsing.
dodexahedron
added a commit
that referenced
this pull request
Apr 23, 2015
New commands parser implications.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the calls to General.SplitString() in order to have a consistent and reliable commands parsing.
I tested it with most commands that can use composed names (player or ship names) and also with timed and triggered cleanups. Everything seems to be working fine!
On a side note: I hesitated to modify the ChatHandlerBase.HandleCommand() virtual method in order to take List instead of string[] but as the commands and parameters should not be modified it's perhaps not worth the modifications.