Skip to content
This repository was archived by the owner on Jun 23, 2023. It is now read-only.

Conversation

@emawind84
Copy link

I just removed a check that prevented the use of ownedby:userid, but I am not sure if it can cause other problems.

@emawind84 emawind84 changed the title Fix for Fix for grids scan to use ownedby:userid Mar 29, 2015
@dodexahedron
Copy link
Member

I'll have a look at this tonight.
Thanks for the contribution. :)

-----Original Message-----
From: "Emanuele Disco" notifications@github.com
Sent: ‎3/‎29/‎2015 2:28 AM
To: "SEServerExtender/EssentialsPlugin" EssentialsPlugin@noreply.github.com
Subject: [EssentialsPlugin] Fix for (#8)

You can view, comment on, or merge this pull request online at:
#8
Commit Summary
removed a check in ScanGrids that prevented the use of options like ownedby:userid
Revert "removed a check in ScanGrids that prevented the use of options like ownedby:userid"
Fix for scan function that prevented the use of options like ownedby:userid
File Changes
M EssentialsPlugin/Utility/CubeGrid.cs (18)
Patch Links:
https://github.com/SEServerExtender/EssentialsPlugin/pull/8.patch
https://github.com/SEServerExtender/EssentialsPlugin/pull/8.diff

Reply to this email directly or view it on GitHub.

@dodexahedron
Copy link
Member

That check is pretty important. If your commands fail to parse properly, it'll just return a bunch of stuff you don't want, which can result in deleting everything or the wrong things in a cleanup.
I'm not going to merge this one.
Also, there are other changes in here that shouldn't be merged in, such as the auto version increment pre-build event being removed.
I'll probably just end up reverting back to the original argument parser for the time being. The original bug I set out to fix with the new parser will come back, but there are more bugs with the new one, so...
I'll just have to re-build the parser from the ground up, rather than trying to modify it from the old one (as I did this time). It really should be a state machine or else have its syntax redefined.

@dodexahedron
Copy link
Member

Wow github is having some weird problems, today.
I had to post that 5 times before it stopped throwing errors at me and just posted.
In any case, I see that you backed out the invalid changes before finally pushing.
I'm still not going to merge the removal of the argument length check, though, because, as I said, I'll just undo all my changes to the argument parser for now to get it back to a mostly-working state, before I completely re-work it.
Again, thanks for the contribution, though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants