Skip to content

Remove Cassini ISS offset#124

Merged
jnspitale merged 1 commit intomainfrom
rf_remove_offset
Mar 4, 2024
Merged

Remove Cassini ISS offset#124
jnspitale merged 1 commit intomainfrom
rf_remove_offset

Conversation

@rfrenchseti
Copy link
Copy Markdown
Collaborator

@rfrenchseti rfrenchseti commented Mar 4, 2024

There is a NAC/WAC offset hard-coded in the Cassini ISS hosts module that I derived from previous navigation work, but I do not have confidence in this number or (based on information from Joe) the possibility that it might vary over time. Thus I'm turning it off by default until we can do further analysis. I think having the offset on by default will do more potential damage. I also removed the same copied code from JUNOCAM, even though that code is apparently never called. All tests still pass with current gold backplanes.

Fixes #96

@rfrenchseti rfrenchseti requested a review from jnspitale March 4, 2024 20:41
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.10%. Comparing base (435bae3) to head (088489c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   77.10%   77.10%           
=======================================
  Files         134      134           
  Lines       24821    24821           
  Branches     2834     2834           
=======================================
  Hits        19137    19137           
  Misses       4829     4829           
  Partials      855      855           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@jnspitale jnspitale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds good to me. The Junocam argument was left over from copying and modifying the Cassini module.

@jnspitale jnspitale merged commit 08066b3 into main Mar 4, 2024
@jnspitale jnspitale deleted the rf_remove_offset branch March 4, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate offsets in oops hosts

2 participants