Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
=======================================
Coverage 77.10% 77.10%
=======================================
Files 134 134
Lines 24821 24821
Branches 2834 2834
=======================================
Hits 19137 19137
Misses 4829 4829
Partials 855 855 ☔ View full report in Codecov by Sentry. |
jnspitale
approved these changes
Mar 4, 2024
Collaborator
jnspitale
left a comment
There was a problem hiding this comment.
This sounds good to me. The Junocam argument was left over from copying and modifying the Cassini module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a NAC/WAC offset hard-coded in the Cassini ISS hosts module that I derived from previous navigation work, but I do not have confidence in this number or (based on information from Joe) the possibility that it might vary over time. Thus I'm turning it off by default until we can do further analysis. I think having the offset on by default will do more potential damage. I also removed the same copied code from JUNOCAM, even though that code is apparently never called. All tests still pass with current gold backplanes.
Fixes #96