Cleanup of error logging in gold_master.py and Galileo SSI#132
Merged
rfrenchseti merged 1 commit intomainfrom Jun 17, 2024
Merged
Cleanup of error logging in gold_master.py and Galileo SSI#132rfrenchseti merged 1 commit intomainfrom
rfrenchseti merged 1 commit intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
- Coverage 75.44% 75.39% -0.05%
==========================================
Files 192 192
Lines 24078 24082 +4
Branches 2900 2906 +6
==========================================
- Hits 18165 18156 -9
- Misses 5079 5088 +9
- Partials 834 838 +4 ☔ View full report in Codecov by Sentry. |
jnspitale
approved these changes
Jun 11, 2024
Collaborator
jnspitale
left a comment
There was a problem hiding this comment.
Loosk good, all unit test pass. It looks like I miust have had some extraneous overrides in the galileo ssi standard_obs file.
Collaborator
Author
In the third test, there were a bunch of Europa overrides, but they were applied to an Earth observation so they never got used. The Europa overrides were only needed for the fourth test. |
rfrenchseti
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains fixes to how errors are logged. It was part of the previous pull request but that one got merged before I had pushed these changes.
In the LOGGING methods in
oops/config.py:print(), literal messages no longer get counted as warnings or errors, even if the level is WARN or ERROR. This is consistent with the point of literal messages, which is to add supplementary info to the log. Supplementary info about a warning or error should not increment the count.In
oops/gold_master/__init__.py:define_standard_obs().LOGGING.pop()is always called afterLOGGING.push()using try/finally.For Galileo SSI:
define_standard_obs(), taking advantage of the new input defaults.