Merged
Conversation
- compute mask using window given in label. - add mask to observation.
- added gold master tests for cassini uvis -- fails because uvis needs updating - added gold master tests for cassini vims -- fails because vims needs updating - added gold master tests for juno jiram -- not yet tested - made junocam gold master unit test consistent w style of other hosts
- added gold master tests for voyager ISS -- not yet tested
- removed backplane/unittester_support.py, backplane_exercises.py
…does not currently allow arguments to be passed in this way.
- import standard_obs in junocam/__init__.py and junocam/__init__goldmaster.py - gm.override modified to be observation-specific
- added gm.execute_standard_command()
- gm.execute_standard_unittest() runs all standard observations if name not given - added exclude arguments to gm.execute_standard_unittest() and gm.execute_standard_command()
…er_x_coordinate()
- added backplane.sphere.center_x_coordinate(), backplane.sphere.center_x_coordinate()
- added ring_system_body attribute to Body class
…m() to backplane.ring.py
…ional argument - removed ring_system_body
- added scaled option to backplane.limb.limb_altitude()
markshowalter
requested changes
Mar 12, 2025
Collaborator
markshowalter
left a comment
markshowalter
left a comment
There was a problem hiding this comment.
This is good code but I have a bunch of comments, as usual.
Collaborator
Author
|
Just pushed new commit with the requested changes. |
markshowalter
requested changes
Mar 18, 2025
Collaborator
markshowalter
left a comment
markshowalter
left a comment
There was a problem hiding this comment.
Scattered remaining comments.
…exactly to the comment and simplified the accompanying code.
- change asserts to raises in ring.py and pixel.py - other changes in response to Mark's comments
Collaborator
|
I know this isn't ready for review, but I have two quick comments.
|
Collaborator
Author
|
The asserts should already be gone. |
Collaborator
Author
|
I would advocate changing to uv in center_coordinates. OPUS users only see the column names, which are written as X and Y. |
markshowalter
requested changes
Mar 20, 2025
markshowalter
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly updates for the new backplanes. There is also a fix to the Galileo SSI module to properly recognize a null CUT_OUT_WINDOW.
I don't know why there is a mod to nircam. So maybe that shouldn't be there.