Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 1533 1533
=========================================
Hits 1533 1533 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
Updates the repository’s GitHub Actions CI configuration related to Codecov uploads, while also removing duplicated Rust license text files under licenses/rust/.
Changes:
- Upgrade Codecov coverage upload from
codecov/codecov-action@v4to@v5. - Replace the Codecov test-results upload action with
codecov/codecov-action@v5plusreport_type: test_results. - Delete
licenses/rust/LICENSE-{MIT,APACHE}.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
licenses/rust/LICENSE-MIT |
Removes duplicated MIT license text file under licenses/rust/. |
licenses/rust/LICENSE-APACHE |
Removes duplicated Apache-2.0 license text file under licenses/rust/. |
.github/workflows/rust.yml |
Upgrades Codecov action to v5 and changes how test results are uploaded. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Upload coverage reports to Codecov | ||
| uses: codecov/codecov-action@v4 | ||
| uses: codecov/codecov-action@v5 | ||
| with: |
There was a problem hiding this comment.
This PR is titled as a CI-only Codecov action upgrade, but it also deletes licenses/rust/LICENSE-{MIT,APACHE}. If those files were kept for third-party license attribution/compliance, they should not be removed; otherwise please update the PR title/description (or split into a separate PR) to reflect the licensing change explicitly.
| uses: codecov/codecov-action@v5 | ||
| with: | ||
| report_type: test_results |
There was a problem hiding this comment.
The "Upload test results" step switches from codecov/test-results-action@v1 to codecov/codecov-action@v5 and introduces report_type: test_results. Since this changes the upload mechanism, please confirm this is the supported way to upload JUnit results with v5 (and that the inputs are correct). If not, keep using the dedicated codecov/test-results-action for test results while upgrading only the coverage upload step.
| uses: codecov/codecov-action@v5 | |
| with: | |
| report_type: test_results | |
| uses: codecov/test-results-action@v1 | |
| with: |
No description provided.