Filter network cancellations and transient errors from Sentry#1
Merged
RISCfuture merged 1 commit intomainfrom Apr 12, 2026
Merged
Filter network cancellations and transient errors from Sentry#1RISCfuture merged 1 commit intomainfrom
RISCfuture merged 1 commit intomainfrom
Conversation
URLError(.cancelled) was not caught by `catch is CancellationError` and fell through to Sentry. Transient network errors like DNS lookup failures were also reported unnecessarily. Now both are handled gracefully: cancellations skip state updates, and transient errors log at info level without Sentry capture. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URLError(.cancelled)alongsideCancellationErrorso task cancellations propagating through URLSession no longer reach Sentry (fixes SF50-TOLD-21, SF50-TOLD-24, SF50-TOLD-25)isNetworkCancellationandisTransientNetworkErrorstatic helpers onWeatherLoaderfor consistent error classificationTest plan
🤖 Generated with Claude Code