Configure .NET analyzer and code style settings #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marioalexsan
force-pushed
the
code-style
branch
2 times, most recently
from
9e3ed2b to
794e63c
Compare
eXpl0it3r
reviewed
Aug 31, 2024
eXpl0it3r
reviewed
Aug 31, 2024
Marioalexsan
force-pushed
the
code-style
branch
2 times, most recently
from
2669549 to
de31af0
Compare
eXpl0it3r
reviewed
Aug 31, 2024
eXpl0it3r
reviewed
Sep 2, 2024
eXpl0it3r
reviewed
Sep 2, 2024
Marioalexsan
force-pushed
the
code-style
branch
from
9147398 to
593963a
Compare
eXpl0it3r
approved these changes
Sep 4, 2024
Member
eXpl0it3r
left a comment
eXpl0it3r
left a comment
There was a problem hiding this comment.
Looks good!
You may want to squash merge, unless you think the separate commits help in some way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switches code style setup from
.editorconfig+omnisharp.jsonto.editorconfig+ .NET's built-in analyzers. The main idea is to setup proper code rules that can also be enforced at compile time if needed.I've split it into two commits: the one that configures the rules, and the one that fixes all of the warnings generated by said rules.
How to test?
Grab the branch and build it, then go back a commit and check what warnings were being generated for the previous version of the code base.
Breaking Changes
I-prefix in their namecamelCaseinstead ofPascalCaseSFML.Audioinstead ofSFML.audioM1instead ofm1) that are internally accessible