Skip to content

Miscellaneous C++ updates #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TheJJ merged 5 commits into from
May 14, 2018
Merged

Miscellaneous C++ updates #48

TheJJ merged 5 commits into from
May 14, 2018

Conversation

@tusharpm
Copy link
Member

@tusharpm tusharpm commented May 11, 2018

Summary

  • Modernization and replacements suggested by clang-tidy
  • Readability enhancement by cleanup of verbose code
  • Logic simplification in some places
  • Remove warnings from flex-emitted code

@tusharpm tusharpm requested a review from TheJJ May 11, 2018 17:16
@tusharpm tusharpm force-pushed the miscellaneous branch 2 times, most recently from 4063f22 to 5dea68f Compare May 11, 2018 17:24
TheJJ
TheJJ approved these changes May 14, 2018
View reviewed changes
Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great improvements! especially with the iterators.

@TheJJ TheJJ merged commit 6c00460 into SFTtech:master May 14, 2018
@tusharpm tusharpm deleted the miscellaneous branch May 18, 2018 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheJJ TheJJ TheJJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tusharpm @TheJJ