#28 Cycle Archive/Management Page by Copilot · Pull Request #35 · SGAOperations/senate-path

Copilot · 2026-02-23T03:12:55Z

Explore repository structure and understand patterns
Add getCyclesWithCounts() to lib/data/cycles.ts
Create lib/actions/cycles.ts with createCycle, setActiveCycle, deleteCycle server actions
Create colocated components in app/admin/cycles/
Create app/admin/cycles/page.tsx admin page
Add "Manage Cycles" link to admin dashboard (app/admin/page.tsx)
Address review round 1: colocate components, React Hook Form, fix link, error handling, revalidatePath
Address review round 2: AlertDialog, error type helper, revalidatePath cleanup, RHF setError
Fix build error: move isActionError / ActionError to lib/actions/utils.ts (non-server file) — 'use server' files can only export async functions

Original prompt

This section details on the original issue you should resolve

<issue_title>Cycle Archive/Management Page</issue_title>
<issue_description>#### Context
Admins need UI to view all cycles, create new cycles, and set which cycle is active.

Goal

Build admin page at /admin/cycles to manage cycles.

Features

List View:

Table/cards showing all cycles (active and inactive)

Display: name, active status badge, counts (applications, nominations, endorsements), created date

Active cycle visually highlighted

"Create New Cycle" button at top

For each inactive cycle: "Set Active" button

For each cycle: "View Details" link (goes to /cycles/[id])

Create Cycle Modal:

Text input for cycle name (required)

Two buttons: "Create & Set Active" and "Create as Inactive"

"Create & Set Active": Creates cycle with isActive = true, deactivates others

"Create as Inactive": Creates cycle with isActive = false

Set Active Flow:

Click "Set Active" on inactive cycle

Confirmation modal: "This will make [Cycle Name] the active cycle. All new applications will go to this cycle. Continue?"

On confirm: Set selected isActive = true, all others isActive = false

If cycle has no settings, create default Settings record

Validation:

Cycle name required

Cannot soft delete active cycle

Can soft delete inactive cycles only if no data (applications, nominations, endorsements)

Acceptance Criteria

Page at /admin/cycles displays all cycles

Shows counts for applications, nominations, endorsements per cycle

Active cycle clearly indicated

Can create new cycle with name

"Create & Set Active" sets new cycle active and deactivates others

"Create as Inactive" creates without changing active cycle

"Set Active" button on inactive cycles with confirmation

Cannot delete active cycle

Can delete empty inactive cycles</issue_description>

<agent_instructions>ticket #28</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes b-at-neu/senate-path#28

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

vercel · 2026-02-23T03:12:59Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
senate-path	Ready	Preview, Comment	Feb 23, 2026 4:03am

Co-authored-by: b-at-neu <144247685+b-at-neu@users.noreply.github.com>

b-at-neu · 2026-02-23T03:27:10Z

+};
+
+interface CyclesManagerProps {
+  cycles: CycleWithCounts[];


this can be in one interface together

Done in 8116744. CycleWithCounts is now a single exported interface and CyclesManagerProps references it directly.

b-at-neu · 2026-02-23T03:27:39Z

+export default function CyclesManager({ cycles }: CyclesManagerProps) {
+  const router = useRouter();
+
+  // Create modal state


use react hook form

Done in 8116744. The create cycle modal now uses React Hook Form with a Zod schema (name: z.string().min(1, 'Cycle name is required')). Two handleSubmit wrappers are created via a shared handleCreate(setActive) factory to handle the "Create as Inactive" vs "Create & Set Active" split.

b-at-neu · 2026-02-23T03:28:40Z

+                    </TableCell>
+                    <TableCell className="text-right">
+                      <div className="flex justify-end gap-2">
+                        <Link href={`/cycles/${cycle.id}`}>


This should go to /admin/cycles/[id]

Fixed in 8116744 — the View link now goes to /admin/cycles/${cycle.id}.

b-at-neu · 2026-02-23T03:29:14Z

@@ -0,0 +1,292 @@
+'use client';


lets split up this file into smaller components, also we can colocate this with the only page its on

Done in 8116744. Removed components/CyclesManager.tsx and split into three colocated files in app/admin/cycles/: cycles-manager.tsx (table + state orchestration), create-cycle-modal.tsx (create form), and set-active-modal.tsx (confirmation modal).

b-at-neu · 2026-02-23T03:29:40Z

+ * Create a new cycle. If setActive is true, deactivate all other cycles.
+ */
+export async function createCycle(name: string, setActive: boolean) {
+  if (!name.trim()) {


this can be handled with zod validation on client side

Removed in 8116744. Name validation is now handled entirely by the Zod schema in create-cycle-modal.tsx.

b-at-neu · 2026-02-23T03:31:08Z

+
+    return { success: true };
+  } catch (error) {
+    console.error('Error setting active cycle:', error);


this isn't graceful, see how error handling works elsewhere

Updated in 8116744 to return { success: false, error: 'Failed to set active cycle' } — static string matching the settings.ts pattern.

b-at-neu · 2026-02-23T03:31:31Z

+    return { success: true };
+  } catch (error) {
+    console.error('Error deleting cycle:', error);
+    return {


handle errors more gracefully

Updated in 8116744 to return { success: false, error: 'Failed to delete cycle' } — static string matching the settings.ts pattern.

…w link, clean up actions Co-authored-by: b-at-neu <144247685+b-at-neu@users.noreply.github.com>

b-at-neu · 2026-02-23T03:41:15Z

+            : `Cycle "${data.name}" created`
+        );
+        onClose();
+        router.refresh();


we already revalidate the page

Removed in ba91dc2 — router.refresh() and the useRouter import are gone from create-cycle-modal.tsx. The revalidatePath('/admin') in the server action is sufficient.

b-at-neu · 2026-02-23T03:41:36Z

+        onClose();
+        router.refresh();
+      } else {
+        setServerError(result.error || 'Failed to create cycle');


why does this have to be a useState? Can't we use react hook form properly?

Fixed in ba91dc2. Replaced useState(serverError) with RHF's setError('root', { message: result.error }). The error is now read from errors.root?.message instead.

b-at-neu · 2026-02-23T03:42:36Z

+                            Set Active
+                          </Button>
+                        )}
+                        {!cycle.isActive && isEmpty(cycle) && (


lets deactivate this button on empty, not remove it

Updated in ba91dc2 — the delete button is now always rendered for inactive cycles but has disabled={!isEmpty(cycle)} when the cycle has data.

b-at-neu · 2026-02-23T03:42:55Z

+    if (result.success) {
+      toast.success(`"${cycle.name}" is now the active cycle`);
+      onClose();
+      router.refresh();


why do we need this?

Removed in ba91dc2. Switched to AlertDialog which handles its own open/close lifecycle, so no useState or useRouter is needed.

b-at-neu · 2026-02-23T03:43:30Z

+  };
+
+  return (
+    <div className="fixed inset-0 z-50 flex items-center justify-center bg-black/50">


don't do this, just use a dialog or alertdialog from shadcn

Done in ba91dc2. Added @radix-ui/react-alert-dialog and the standard shadcn AlertDialog component (components/ui/alert-dialog.tsx), then rewrote set-active-modal.tsx to use AlertDialogContent, AlertDialogHeader, AlertDialogFooter, AlertDialogAction, and AlertDialogCancel.

b-at-neu · 2026-02-23T03:44:43Z

+    return { success: true, cycle };
+  } catch (error) {
+    console.error('Error creating cycle:', error);
+    return { success: false, error: 'Failed to create cycle' };


You don't need to console error. also just return { error: text }

you don't need the sucess false, just make an errortype and have a helper to check for it,

Done in ba91dc2. Removed all console.error calls. Introduced ActionError = { error: string } type, isActionError(result: unknown): result is ActionError helper, and changed all returns to { error: 'message' } on failure and { cycle } / {} on success. The success boolean is gone entirely.

Done in ba91dc2 — see above reply.

…ePath cleanup, rhf setError Co-authored-by: b-at-neu <144247685+b-at-neu@users.noreply.github.com>

b-at-neu · 2026-02-23T03:59:22Z

@copilot

Build error occurred
Error: Turbopack build failed with 7 errors:
./lib/actions/cycles.ts:9:17
Ecmascript file had an error
7 | type ActionError = { error: string };
8 |
9 | export function isActionError(result: unknown): result is ActionError {
| ^^^^^^^^^^^^^
10 | return typeof result === 'object' && result !== null && 'error' in result;
11 | }
12 |

…ib/actions/utils.ts Co-authored-by: b-at-neu <144247685+b-at-neu@users.noreply.github.com>

Copilot · 2026-02-23T04:00:44Z

@copilot

Build error occurred
...

Fixed in 74b218e. The root cause was that 'use server' files can only export async functions — exporting the synchronous isActionError broke the build. Moved ActionError and isActionError to a new lib/actions/utils.ts file (no directive), and updated the three client components and cycles.ts to import from there.

Initial plan

f0a3c55

Copilot AI assigned Copilot and b-at-neu Feb 23, 2026

Copilot started work on behalf of b-at-neu February 23, 2026 03:13 View session

vercel Bot deployed to Preview February 23, 2026 03:17 View deployment

#28 add cycle archive/management page at /admin/cycles

6dde72b

Co-authored-by: b-at-neu <144247685+b-at-neu@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add admin page for cycle management~~ #28 Cycle Archive/Management Page Feb 23, 2026

Copilot AI requested a review from b-at-neu February 23, 2026 03:19

Copilot finished work on behalf of b-at-neu February 23, 2026 03:19

vercel Bot deployed to Preview February 23, 2026 03:22 View deployment

b-at-neu requested changes Feb 23, 2026

View reviewed changes

Copilot started work on behalf of b-at-neu February 23, 2026 03:32 View session

#28 address review: colocate components, use react hook form, fix vie…

8116744

…w link, clean up actions Co-authored-by: b-at-neu <144247685+b-at-neu@users.noreply.github.com>

vercel Bot deployed to Preview February 23, 2026 03:39 View deployment

Copilot AI requested a review from b-at-neu February 23, 2026 03:39

Copilot finished work on behalf of b-at-neu February 23, 2026 03:39

b-at-neu requested changes Feb 23, 2026

View reviewed changes

Copilot started work on behalf of b-at-neu February 23, 2026 03:45 View session

#28 address review round 2: alertdialog, error type helper, revalidat…

ba91dc2

…ePath cleanup, rhf setError Co-authored-by: b-at-neu <144247685+b-at-neu@users.noreply.github.com>

Copilot AI requested a review from b-at-neu February 23, 2026 03:55

Copilot finished work on behalf of b-at-neu February 23, 2026 03:55

vercel Bot had a problem deploying to Preview February 23, 2026 03:55 Failure

Copilot started work on behalf of b-at-neu February 23, 2026 03:59 View session

#28 fix build error: move isActionError out of use server file into l…

74b218e

…ib/actions/utils.ts Co-authored-by: b-at-neu <144247685+b-at-neu@users.noreply.github.com>

Copilot finished work on behalf of b-at-neu February 23, 2026 04:01

vercel Bot deployed to Preview February 23, 2026 04:03 View deployment

b-at-neu approved these changes Feb 23, 2026

View reviewed changes

b-at-neu marked this pull request as ready for review February 23, 2026 04:05

b-at-neu merged commit 6261077 into dev Feb 23, 2026
2 checks passed

b-at-neu deleted the copilot/add-admin-cycles-page branch February 23, 2026 04:05

Conversation

Copilot AI commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Goal

Features

Acceptance Criteria

Comments on the Issue (you are @copilot in this section)

Uh oh!

vercel Bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Copilot AI commented Feb 23, 2026 •

edited

Loading

vercel Bot commented Feb 23, 2026 •

edited

Loading