Skip to content

# Release 2.2.0#3

Merged
golluroSICKAG merged 7 commits intoSICKAppSpaceCodingStarterKit:mainfrom
golluroSICKAG:main
Nov 28, 2024
Merged

# Release 2.2.0#3
golluroSICKAG merged 7 commits intoSICKAppSpaceCodingStarterKit:mainfrom
golluroSICKAG:main

Conversation

@golluroSICKAG
Copy link
Copy Markdown
Contributor

@golluroSICKAG golluroSICKAG commented Aug 14, 2024

Version 2.2.0

New features

  • Provide version of module via 'OnNewStatusModuleVersion'
  • Function 'getParameters' to provide PersistentData parameters
  • Check if features of module can be used on device and provide this via 'OnNewStatusModuleIsActive' event / 'getStatusModuleActive' function

Improvements

  • New UI design available (e.g. selectable via CSK_Module_PersistentData v4.1.0 or higher), see 'OnNewStatusCSKStyle'
  • 'loadParameters' returns its success
  • 'sendParameters' can control if sent data should be saved directly by CSK_Module_PersistentData
  • Added browser tab information

Following tasks were checked

  • Module is coded and structured according to the "Developing guideline for modules" described within the CSK documentation
  • All functions/events/parameters are documented within the manifest documentation
  • The manifest description of the main CROWN includes main information about the purpose of the module and how to use it in general
  • API docu based on the manifest was created and stored within the "docu"-folder of the repository
  • Internal LUA code documentation exists for variables and non served functions
  • All relevant infos are logged via the SharedLogger 'ModuleLogger'
  • Module supports persistent data feature based on 'CSK_Module_PersistentData'
  • Module supports user management based on 'CSK_Module_UserManagement'
  • No open "ToDos" within the code or at least clearly explained comments why they exist...
  • "Version" key in app manifest was updated following semantic versioning (and use '0.x.y' for test / experimental modules which are not yet ready to be officially released)
  • Meaningful IDs used for UI elements
  • Module was tested on an AppSpace device (at least on SICK AppEngine) with no error message
  • README.md is up to date (incl. info of device + firmware the module was tested with)
  • CHANGELOG.md is up to date

@golluroSICKAG
# Release 2.2.0
736de8f 
## New features
- Provide version of module via 'OnNewStatusModuleVersion'
- Function 'getParameters' to provide PersistentData parameters
- Check if features of module can be used on device and provide this via 'OnNewStatusModuleIsActive' event / 'getStatusModuleActive' function

## Improvements
- New UI design available (e.g. selectable via CSK_Module_PersistentData v4.1.0 or higher), see 'OnNewStatusCSKStyle'
- 'loadParameters' returns its success
- 'sendParameters' can control if sent data should be saved directly by CSK_Module_PersistentData
- Added browser tab information
@golluroSICKAG
Minor update of README
8ef1414
@golluroSICKAG
- Update of UI settings
2cb5283
@dzekomiSICKAG dzekomiSICKAG self-requested a review September 23, 2024 07:59
@dzekomiSICKAG
Copy link
Copy Markdown

dzekomiSICKAG commented Sep 23, 2024

image
There is this warning when run on TDC-E AppEngine 2.0.0``

dzekomiSICKAG
dzekomiSICKAG approved these changes Sep 23, 2024
View reviewed changes
Comment thread docu/media/src/UI_sample.pptx
Copy link
Copy Markdown

@dzekomiSICKAG dzekomiSICKAG Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Powerpoint presentation should be in the repo?

Copy link
Copy Markdown
Contributor Author

@golluroSICKAG golluroSICKAG Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is helpful if the UI changed and you need to create a new screenshot with the overlay to implement it into the UI...

@golluroSICKAG
Copy link
Copy Markdown
Contributor Author

golluroSICKAG commented Oct 11, 2024

Thx for the review!
All issues should be fixed.

@golluroSICKAG
- Show timestamp info after ping
95d9547 
- Check interface selection within UI table
- Minor UI changes
@golluroSICKAG golluroSICKAG merged commit 0678b06 into SICKAppSpaceCodingStarterKit:main Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzekomiSICKAG dzekomiSICKAG dzekomiSICKAG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@golluroSICKAG @dzekomiSICKAG