Skip to content

Added Disconnect with Will Message#3

Merged
golluroSICKAG merged 3 commits intoSICKAppSpaceCodingStarterKit:mainfrom
novakroSICKAG:feature/disconnect-with-Will-Message
Apr 18, 2024
Merged

Added Disconnect with Will Message#3
golluroSICKAG merged 3 commits intoSICKAppSpaceCodingStarterKit:mainfrom
novakroSICKAG:feature/disconnect-with-Will-Message

Conversation

@novakroSICKAG
Copy link
Copy Markdown
Contributor

@novakroSICKAG novakroSICKAG commented Apr 18, 2024

Version 1.1.0

New features

Added optional setting to enable the MQTT client to Disconnect with Will Message. If enabled, a Will Message will be sent before intentionally disconnecting.

Improvements

...

Bugfix

...

Following tasks were checked

  • Module is coded and structured according to the "Developing guideline for modules" described within the CSK documentation
  • All functions/events/parameters are documented within the manifest documentation
  • The manifest description of the main CROWN includes main information about the purpose of the module and how to use it in general
  • API docu based on the manifest was created and stored within the "docu"-folder of the repository
  • Internal LUA code documentation exists for variables and non served functions
  • All relevant infos are logged via the SharedLogger 'ModuleLogger'
  • Module supports persistent data feature based on 'CSK_Module_PersistentData'
  • Module supports user management based on 'CSK_Module_UserManagement'
  • No open "ToDos" within the code or at least clearly explained comments why they exist...
  • "Version" key in app manifest was updated following semantic versioning (and use '0.x.y' for test / experimental modules which are not yet ready to be officially released)
  • Meaningful IDs used for UI elements
  • Module was tested on an AppSpace device (at least on SICK AppEngine) with no error message
  • README.md is up to date (incl. info of device + firmware the module was tested with)
  • CHANGELOG.md is up to date

@golluroSICKAG
Copy link
Copy Markdown
Contributor

Thx for your contribution! It looks very well done!
I made some edits and created a PR to your repo
Please merge it to your repo if these changes are ok for you. After that I will merge it to the official repository.
Thx again!

@novakroSICKAG
Copy link
Copy Markdown
Contributor Author

I merged your changes to my repo. Thank you for your cooperation!

@golluroSICKAG golluroSICKAG merged commit 0ce0c25 into SICKAppSpaceCodingStarterKit:main Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants