Skip to content

Release 2.0.1#3

Merged
golluroSICKAG merged 5 commits intoSICKAppSpaceCodingStarterKit:mainfrom
golluroSICKAG:main
Oct 30, 2025
Merged

Release 2.0.1#3
golluroSICKAG merged 5 commits intoSICKAppSpaceCodingStarterKit:mainfrom
golluroSICKAG:main

Conversation

@golluroSICKAG
Copy link
Copy Markdown
Contributor

@golluroSICKAG golluroSICKAG commented Jul 28, 2025

Release 2.0.1

Improvements

  • Better instance handling regarding FlowConfig

Bugfix

  • Wrong ENUM check within checkAPI
  • Legacy bindings of ValueDisplay elements within UI did not work if deployed with VS Code AppSpace SDK
  • UI differs if deployed via Appstudio or VS Code AppSpace SDK
  • Fullscreen icon of iFrame was visible

Following tasks were checked

  • Module is coded and structured according to the "Developing guideline for modules" described within the CSK documentation
  • All functions/events/parameters are documented within the manifest documentation
  • The manifest description of the main CROWN includes main information about the purpose of the module and how to use it in general
  • API docu based on the manifest was created and stored within the "docu"-folder of the repository
  • Internal LUA code documentation exists for variables and non served functions
  • All relevant infos are logged via the SharedLogger 'ModuleLogger'
  • Module supports persistent data feature based on 'CSK_Module_PersistentData'
  • Module supports user management based on 'CSK_Module_UserManagement'
  • No open "ToDos" within the code or at least clearly explained comments why they exist...
  • "Version" key in app manifest was updated following semantic versioning (and use '0.x.y' for test / experimental modules which are not yet ready to be officially released)
  • Meaningful IDs used for UI elements
  • Module was tested on an AppSpace device (at least on SICK AppEngine) with no error message
  • README.md is up to date (incl. info of device + firmware the module was tested with)
  • CHANGELOG.md is up to date

golluroSICKAG and others added 4 commits December 10, 2024 09:02
@golluroSICKAG
# Release 1.0.1
aa2f21e 
## Bugfix
- Registering to external function did not work
@golluroSICKAG
# Release 2.0.0
daa6071 
Major change: Handles serial data as binary (was string before)

## New features
- Supports FlowConfig feature to handle received data / transmit data
- Optionally deactivate logging of serial communication to reduce CPU load
- Provide version of module via 'OnNewStatusModuleVersion'
- Function 'getParameters' to provide PersistentData parameters
- Check if features of module can be used on device and provide this via 'OnNewStatusModuleIsActive' event / 'getStatusModuleActive' function
- Function to 'resetModule' to default setup
- Check if persistent data to load provides all relevant parameters. Otherwise add default values.

## Improvements
- New UI design available (e.g. selectable via CSK_Module_PersistentData v4.1.0 or higher), see 'OnNewStatusCSKStyle'
- check if instance exists if selected
- 'loadParameters' returns its success
- 'sendParameters' can control if sent data should be saved directly by CSK_Module_PersistentData
- Added UI icon and browser tab information
@golluroSICKAG
Merge branch 'SICKAppSpaceCodingStarterKit:main' into main
75b5036
@golluroSICKAG
# Release 2.0.1
9b9e676 
## Improvements
- Better instance handling regarding FlowConfig

## Bugfix
- Wrong ENUM check within checkAPI
- Legacy bindings of ValueDisplay elements within UI did not work if deployed with VS Code AppSpace SDK
- UI differs if deployed via Appstudio or VS Code AppSpace SDK
- Fullscreen icon of iFrame was visible
kogliinSICKAG
kogliinSICKAG approved these changes Oct 16, 2025
View reviewed changes
Copy link
Copy Markdown

@kogliinSICKAG kogliinSICKAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented some lines but did not find a bug or show stopper. Thus, I will approve it even without running a test on a device.

Comment thread CSK_Module_MultiSerialCom/pages/pages/CSK_Module_MultiSerialCom/CSK_Module_MultiSerialCom.html Outdated
Comment thread CSK_Module_MultiSerialCom/pages/pages/CSK_Module_MultiSerialCom/CSK_Module_MultiSerialCom.html Outdated
Comment thread CSK_Module_MultiSerialCom/pages/pages/CSK_Module_MultiSerialCom/CSK_Module_MultiSerialCom.html Outdated
Comment thread CSK_Module_MultiSerialCom/pages/pages/CSK_Module_MultiSerialCom/CSK_Module_MultiSerialCom.html Outdated
Comment thread CSK_Module_MultiSerialCom/pages/src/converter.ts
Comment thread CSK_Module_MultiSerialCom/project.mf.xml
Comment thread ...MultiSerialCom/scripts/Communication/MultiSerialCom/FlowConfig/MultiSerialCom_FlowConfig.lua
@golluroSICKAG
Copy link
Copy Markdown
Contributor Author

golluroSICKAG commented Oct 30, 2025

Thx for the review!

@golluroSICKAG golluroSICKAG merged commit 8bcc264 into SICKAppSpaceCodingStarterKit:main Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kogliinSICKAG kogliinSICKAG kogliinSICKAG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@golluroSICKAG @kogliinSICKAG