JLSRTP: Add comments explaining string reserve sizes#823
Merged
Conversation
orgads
force-pushed
the
jlsrtp-comments
branch
from
34f315e to
20dffd5
Compare
orgads
referenced
this pull request
Dec 9, 2025
Contributor
|
@orgads : Sorry for the delay - right now I'm so buried in new-dad work that I pretty much only have a few hours max for SIPP once a week. I've reviewed both commits post-merge and they all look fine to me. |
Contributor
Author
|
Congratulations :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jeannotlanglois Please review.