Conversation
…IT/sisc-web into 20260313-#-306-워치리스트-기능-개선
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughPatchTST 및 ITransformer 모델의 훈련 및 추론 API를 재설계하여 설정 기반 접근에서 ndarray 중심 인터페이스로 전환했습니다. 새 Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant PatchTST_train
participant DataLoader
participant Model
participant Device
Client->>PatchTST_train: run_training(X_train, y_train, X_val, y_val)
PatchTST_train->>DataLoader: TensorDataset(X_train, y_train) → DataLoader
PatchTST_train->>Device: Select CUDA/CPU device
PatchTST_train->>Model: train_model(train_loader, val_loader)
Model->>Model: Train epochs with batch_size
Model-->>Client: Return trained model
participant Wrapper
Client->>Wrapper: predict(X_input: ndarray)
Wrapper->>Model: Forward pass
Model->>Wrapper: Sigmoid probabilities
Wrapper-->>Client: Return ndarray
Client->>Wrapper: get_signals(df)
Wrapper->>Wrapper: Validate & prepare window
Wrapper->>Wrapper: predict() → score
Wrapper-->>Client: Return {patchtst_1d: score}
sequenceDiagram
participant CLI
participant train_single_pipeline
participant ArtifactResolver
participant TrainingPipeline
participant Serializer
CLI->>train_single_pipeline: --save-dir=X --artifact-mode=prod
train_single_pipeline->>ArtifactResolver: _resolve_itransformer_artifacts(save_dir, artifact_mode)
ArtifactResolver->>ArtifactResolver: Load trading_config if no save_dir
ArtifactResolver-->>train_single_pipeline: (weights_dir, scaler_path, metadata_path, ...)
train_single_pipeline->>TrainingPipeline: train_single_pipeline(resolved paths)
TrainingPipeline->>TrainingPipeline: Train model
TrainingPipeline->>Serializer: pickle.dump(scaler) to scaler_path
Serializer-->>TrainingPipeline: ✓
TrainingPipeline->>Serializer: save_training_metadata(metadata_path)
Serializer-->>CLI: Training complete
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
릴리스 노트
새로운 기능
개선