Conversation
…solves #440) Upstream commit cb2bba6b04 (v261-rc1) removed config_parse_dhcp_server_relay_agent_suboption and deprecated RelayTarget/RelayAgentCircuitId/RelayAgentRemoteId in [DHCPServer], dropping their man-page entries. A companion commit 1a75eb7d8b introduced a replacement [DHCPRelay] section, but only in v261-rc1+. - Remove the now-orphaned config_parse_dhcp_server_relay_agent_suboption validator class and registration (no gperf entry references it anymore). - Mark the three deprecated keys in undocumentedSectionToKeywordMap.json with version-aware wording so v260 users aren't steered toward a section that doesn't exist on their systemd. - Bump OptionValueTest burn-down startingCount 612 -> 619 for ~1 week of buffer; the burn-down naturally caught up to the missing-validator count. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Test Results1 014 tests 1 014 ✅ 43s ⏱️ Results for commit 28ecc65. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cb2bba6b04(deprecatedRelayTarget/RelayAgentCircuitId/RelayAgentRemoteIdin[DHCPServer]and removedconfig_parse_dhcp_server_relay_agent_suboption) and1a75eb7d8b(added the replacement[DHCPRelay]section, v261-rc1+ only).undocumentedSectionToKeywordMap.jsonwith version-aware wording so v260 users aren't steered toward a section they don't have, and bumps theOptionValueTestburn-downstartingCount612 → 619 for ~1 week of buffer.Resolves #440.
Test plan
SemanticDataDocumentationCompletionTestpassesSemanticDataRepositoryTestpassesOptionValueTestpasses./gradlew test -x generateDataFromManPages, 1016 tests)Notes
[DHCPRelay]section was added 2026-05-03 and is only in v261-rc1 (tagged 2026-05-22) — not in v260.1 stable. The deprecation description reflects that so v260 users aren't told to migrate to a section that doesn't exist on their systemd../gradlew generateDataFromManPagesfails locally withCould not find method getXsltTransformer()after the recent Gradle 9.x compat work in fff9c2e — not addressed here, may want a follow-up.🤖 Generated with Claude Code