cleanup(gpu): delete GPU stubs and migrate native benchmark to DSL#131
Merged
michalharakal merged 1 commit intodevelopfrom May 4, 2026
Merged
cleanup(gpu): delete GPU stubs and migrate native benchmark to DSL#131michalharakal merged 1 commit intodevelopfrom
michalharakal merged 1 commit intodevelopfrom
Conversation
Removes the placeholder GPU code paths in :llm-runtime:kllama and the native benchmark engine. There is no real GPU support in this repo — GpuAttentionBackend, GpuTensorBridge, and the createGpuBridge / createMetalContext / createMlxContext expect/actual chains were stubs that always fell back to CPU. - Delete GpuAttentionBackend.kt and GpuTensorBridge.kt - Strip createGpuTensorBridge / createGraphAccelerator from kllama BackendExpect.kt and the linux/macos/ios actuals (createGraphAccelerator was unused dead code) - Drop createMetalContext / createMlxContext / createGpuBridge from llm-performance macosMain; only availableNativeBackends remains - Rewrite NativeBenchmarkEngine: drop GpuNativeLlamaAdapter and the Metal/MLX scenario adapters; rename scenario to native-cpu-throughput and migrate the CPU adapter to the DSL path (DecoderGgufWeightLoader + LlamaNetworkLoader.fromWeights + OptimizedLLMRuntime DIRECT), mirroring #127's JVM cleanup - Drop GpuAttentionBackend reference from AttentionBackend kdoc Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There is no real GPU support in this repo — the GPU code paths in
`:llm-runtime:kllama` and the native benchmark engine are placeholders
that have never run on GPU and always fall back to CPU. This PR deletes
them and migrates the native benchmark to the DSL path, mirroring the
JVM cleanup from #127.
Net: +73 / −479 across 9 files.
Test plan
🤖 Generated with Claude Code