Skip to content
This repository was archived by the owner on Feb 12, 2021. It is now read-only.

Conversation

@leachjustin18
Copy link

@leachjustin18 leachjustin18 commented Feb 22, 2017

@SKempin for some odd reason I'm having trouble assigning this to you.

Why: Background was not going all the way down in certain view ports.
How: Removed restriction on div.

Why: Not opening window on run of gulp watch.
How: Added parameter to gulp task that opens it.

Why: NPM scripts is standard way of firing off applications.
How: Added scripts -> start: gulp watch. Now you just need to run npm start and the rest is done for you.

…way down in certain view ports. How: Removed restruction on div. Why: Not opening window on run of gulp watch. How: Added paramater to gulp task that opens it. Why: NPM scripts is standard way of firing off applications. How: Added scripts -> start: gulp watch. Now you just need to run npm start and the rest does it for you.
@SKempin SKempin merged commit 1672154 into SKempin:master Feb 22, 2017
@SKempin
Copy link
Owner

SKempin commented Feb 22, 2017

@leachjustin18 Thanks, have merged these however the background issue is still persisting?

@leachjustin18
Copy link
Author

Hmm. I will look into the background thing again. Do you mind telling me what the screen size the issue happens at? I will have a couple ideas, but don't want to submit a false PR.

@leachjustin18 leachjustin18 deleted the feature/background-full-width branch February 23, 2017 14:05
@SKempin
Copy link
Owner

SKempin commented Feb 23, 2017

@leachjustin18 It's happening at wider screen sizes, anything more than 1000 pixels. Thanks.

@leachjustin18
Copy link
Author

@SKempin I'm not able to replicate the issue of the transparent background not being 100% tall:
background

@leachjustin18
Copy link
Author

If there is another issue, I'm not sure what it is?

@leachjustin18
Copy link
Author

If there is. Please create an issue ticket for it and I will be happy to look into it when I get time

@SKempin
Copy link
Owner

SKempin commented Feb 24, 2017

@leachjustin18 I've just tested this again (I'm on a different monitor set up today) and the width does actually seem to be fixed, however I am still getting the issue on a tall window? Are you also experiencing this?

Thanks!

capture

@SKempin
Copy link
Owner

SKempin commented Mar 29, 2017

@leachjustin18 Have just fixed this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants