Coursework2 #22
Open
Coursework2 #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volalex
reviewed
Dec 17, 2022
src/ru/skypro/task/Task.java
Outdated
| var dateIs = LocalDate.parse(date, DateTimeFormatter.ofPattern("dd-MM-yyyy")); | ||
| switch (taskPeriod) { | ||
| case ONE_OFF -> { | ||
| return this.dateTime.toLocalDate() == dateIs; |
There was a problem hiding this comment.
Сравнение я бы сделал через equals все же
volalex
reviewed
Dec 17, 2022
src/ru/skypro/task/Task.java
Outdated
| return this.dateTime.toLocalDate() == dateIs; | ||
| } | ||
| case DAILY -> { | ||
| return this.dateTime.toLocalDate().datesUntil(dateIs.plusDays(1)).anyMatch(t->t.equals(dateIs)); |
There was a problem hiding this comment.
Можно просто сравнить даты, а не высчитывать их стримом
Например ежедневная задача и так будет повторятся каждый день поэтому надо сравнить что дата задачи просто раньше чем переданная дата
такие же правила - можно вывести для каждого типа повторяемости если немного подумать как даты могут быть связаны
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Базовый уровень