Skip to content

fix defaults in cmake #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MeijisIrlnd merged 1 commit into from
Mar 22, 2025
Merged

fix defaults in cmake #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions cmake/mostly_harmless.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ function(mostly_harmless_add_binary_data pluginTarget)
)
set(LIST_ARGS BINARY_SOURCES)
cmake_parse_arguments(ARG "" "${ARGS}" "${LIST_ARGS}" ${ARGN})
if (NOT ARG_TARGET_NAME)
if (NOT DEFINED ARG_TARGET_NAME)
message(FATAL_ERROR "TARGET_NAME is required!")
endif ()
if (NOT ARG_ROOT)
if (NOT DEFINED ARG_ROOT)
message(FATAL_ERROR "ROOT is required!")
endif ()
file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${ARG_TARGET_NAME})
Expand Down Expand Up @@ -79,19 +79,19 @@ function(mostly_harmless_add_plugin targetName)
${ARGN}
)
set(PLUGIN_NAME ${targetName})
if (NOT PLUGIN_FORMATS)
if (NOT DEFINED PLUGIN_FORMATS)
message(FATAL_ERROR "No formats provided! Options are: CLAP VST3 AU Standalone")
endif ()
if (NOT PLUGIN_NEEDS_NOTE_IN_BUS)
if (NOT DEFINED PLUGIN_NEEDS_NOTE_IN_BUS)
set(PLUGIN_NEEDS_NOTE_IN_BUS FALSE)
endif ()
if (NOT PLUGIN_NEEDS_NOTE_OUT_BUS)
if (NOT DEFINED PLUGIN_NEEDS_NOTE_OUT_BUS)
set(PLUGIN_NEEDS_NOTE_OUT_BUS FALSE)
endif ()
if (NOT PLUGIN_NEEDS_AUDIO_IN_BUS)
if (NOT DEFINED PLUGIN_NEEDS_AUDIO_IN_BUS)
set(PLUGIN_NEEDS_AUDIO_IN_BUS TRUE)
endif ()
if (NOT PLUGIN_NEEDS_AUDIO_OUT_BUS)
if (NOT DEFINED PLUGIN_NEEDS_AUDIO_OUT_BUS)
set(PLUGIN_NEEDS_AUDIO_OUT_BUS TRUE)
endif ()
# NOTE BUSSES
Expand Down Expand Up @@ -126,13 +126,13 @@ function(mostly_harmless_add_plugin targetName)
list(TRANSFORM PLUGIN_FEATURES REPLACE "(.+)" "\"\\1\"" OUTPUT_VARIABLE PLUGIN_FEATURES)
list(JOIN PLUGIN_FEATURES ", " PLUGIN_FEATURES)

if (NOT PLUGIN_ID)
if (NOT DEFINED PLUGIN_ID)
message(FATAL_ERROR "An ID is required")
endif ()
if (NOT PLUGIN_NAME)
if (NOT DEFINED PLUGIN_NAME)
message(FATAL_ERROR "A name is required")
endif ()
if (NOT PLUGIN_FEATURES)
if (NOT DEFINED PLUGIN_FEATURES)
message(FATAL_ERROR "At least one feature is required")
endif ()
configure_file(
Expand Down Expand Up @@ -204,22 +204,22 @@ function(mostly_harmless_add_plugin targetName)
list(FIND PLUGIN_FORMATS "AU" INDEX)
if (${INDEX} GREATER -1)
if (APPLE)
if (NOT PLUGIN_AU_BUNDLE_ID)
if (NOT DEFINED PLUGIN_AU_BUNDLE_ID)
message(FATAL_ERROR "AU requires a bundle id!")
endif ()
if (NOT PLUGIN_AU_BUNDLE_VERSION)
if (NOT DEFINED PLUGIN_AU_BUNDLE_VERSION)
message(FATAL_ERROR "AU requires a bundle version!")
endif ()
if (NOT PLUGIN_VENDOR)
if (NOT DEFINED PLUGIN_VENDOR)
message(FATAL_ERROR "AU requires you specify a vendor!")
endif ()
if (NOT PLUGIN_MANUFACTURER_CODE)
if (NOT DEFINED PLUGIN_MANUFACTURER_CODE)
message(FATAL_ERROR "AU requires a manufacturer code!")
endif ()
if (NOT PLUGIN_SUBTYPE_CODE)
if (NOT DEFINED PLUGIN_SUBTYPE_CODE)
message(FATAL_ERROR "AU requires a plugin subtype code!")
endif ()
if (NOT PLUGIN_AU_TYPE)
if (NOT DEFINED PLUGIN_AU_TYPE)
message(FATAL_ERROR "AU requires a type")
endif ()
add_library(${PLUGIN_NAME}_AU MODULE)
Expand Down