Skip to content

chore: remove production environment from build job in publish.yml#294

Merged
ammodev merged 1 commit intoversion/26.1from
chore/update-workflow
Apr 5, 2026
Merged

chore: remove production environment from build job in publish.yml#294
ammodev merged 1 commit intoversion/26.1from
chore/update-workflow

Conversation

@ammodev
Copy link
Copy Markdown
Contributor

@ammodev ammodev commented Apr 5, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 5, 2026 14:08
@ammodev ammodev merged commit c195995 into version/26.1 Apr 5, 2026
6 checks passed
@ammodev ammodev deleted the chore/update-workflow branch April 5, 2026 14:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the production GitHub Environment association from the build job in the release publishing workflow.

Changes:

  • Dropped environment: production from .github/workflows/publish.yml’s build job.

@@ -17,7 +17,6 @@ env:
jobs:
build:
Copy link

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing environment: production also removes GitHub Environment protections for this publishing job (e.g., required reviewers/approvals, environment-scoped secrets, and protection rules). If those safeguards are still desired for releases on version/*, keep the environment on the job or replace it with an equivalent gating mechanism (separate protected job, manual approval, etc.).

Suggested change
build:
build:
environment: production

Copilot uses AI. Check for mistakes.
@@ -17,7 +17,6 @@ env:
jobs:
build:
runs-on: ubuntu-latest
Copy link

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publish.yml doesn’t declare explicit permissions for the GITHUB_TOKEN. Other workflows in this repo do (e.g. .github/workflows/api-dump-version.yml:7-10). Since this workflow creates a GitHub Release, define minimal required permissions at the workflow or job level (at least contents: write) to avoid relying on repository defaults and to keep token scope least-privilege.

Suggested change
runs-on: ubuntu-latest
runs-on: ubuntu-latest
permissions:
contents: write

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants