Skip to content

chore: bump version to 3.0.5 and refactor companion object in SurfPaperPacketApi#300

Merged
ammodev merged 2 commits intoversion/26.1from
fix/packet-api
Apr 6, 2026
Merged

chore: bump version to 3.0.5 and refactor companion object in SurfPaperPacketApi#300
ammodev merged 2 commits intoversion/26.1from
fix/packet-api

Conversation

@ammodev
Copy link
Copy Markdown
Contributor

@ammodev ammodev commented Apr 6, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 6, 2026 00:58
@ammodev ammodev merged commit 5eaa58f into version/26.1 Apr 6, 2026
4 checks passed
@ammodev ammodev deleted the fix/packet-api branch April 6, 2026 00:59
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

⚠️ API/ABI changes detected!

This PR contains changes that modified the public API. To update the reference ABI dumps:

./gradlew updateKotlinAbi
git add **/api/**
git commit -m "Update ABI reference"
git push

After updating, the CI will pass. Make sure the changes are backward compatible.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the project version to 3.0.5 and refactors SurfPaperPacketApi’s companion object to follow the common “delegated companion singleton” pattern used across the Paper APIs.

Changes:

  • Bump Gradle project version from 3.0.43.0.5.
  • Refactor SurfPaperPacketApi companion object to delegate SurfPaperPacketApi to the service-resolved api.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
surf-api-paper/surf-api-paper/src/main/kotlin/dev/slne/surf/api/paper/packet/SurfPaperPacketApi.kt Refactors companion object to companion object : SurfPaperPacketApi by api, keeping INSTANCE as the service entrypoint.
gradle.properties Increments project version to 3.0.5.


companion object {
@JvmStatic
companion object : SurfPaperPacketApi by api {
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing @JvmStatic from the INSTANCE property changes the Java-facing API: callers that previously used SurfPaperPacketApi.getINSTANCE() (and binaries compiled against it) will break and now must use SurfPaperPacketApi.Companion.getINSTANCE(). If Java/source+binary compatibility is intended, keep @JvmStatic on INSTANCE (even with the delegated companion), or explicitly treat this as a breaking API change and version accordingly (and update ABI dump).

Suggested change
companion object : SurfPaperPacketApi by api {
companion object : SurfPaperPacketApi by api {
@JvmStatic

Copilot uses AI. Check for mistakes.
Comment on lines 9 to +10
group=dev.slne.surf.api
version=3.0.4
version=3.0.5
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a patch-version bump, but the companion-object refactor in SurfPaperPacketApi can be a breaking change for Java callers/binary compatibility (loss of getINSTANCE() static accessor without @JvmStatic). Either preserve the previous Java API shape or consider a version bump consistent with a breaking change.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants