🔧 chore(build): add buildConfig plugin and update version in VelocityMain#318
Merged
twisti-dev merged 1 commit intoversion/26.1from Apr 20, 2026
Merged
Conversation
Contributor
twisti-dev
commented
Apr 20, 2026
twisti-dev
commented
- include com.github.gmazzo.buildconfig plugin version 6.0.9 in build.gradle.kts
- update plugin version in VelocityMain to use BuildConfig.VERSION
- add authors to VelocityMain plugin metadata
…Main - include com.github.gmazzo.buildconfig plugin version 6.0.9 in build.gradle.kts - update plugin version in VelocityMain to use BuildConfig.VERSION - add authors to VelocityMain plugin metadata
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Velocity server module to derive plugin metadata version from a generated BuildConfig, and enriches the plugin authors metadata.
Changes:
- Add
com.github.gmazzo.buildconfigusage to generate aBuildConfig.VERSIONconstant. - Update
VelocityMainplugin annotation to useBuildConfig.VERSIONinstead of a hard-coded version. - Expand Velocity plugin
authorsmetadata.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| surf-api-velocity/surf-api-velocity-server/src/main/kotlin/dev/slne/surf/api/velocity/server/VelocityMain.kt | Switches plugin annotation version to BuildConfig.VERSION and updates authors list. |
| surf-api-velocity/surf-api-velocity-server/build.gradle.kts | Applies BuildConfig plugin and configures generation of a VERSION field in a generated package. |
| plugins { | ||
| `core-convention` | ||
| kotlin("kapt") | ||
| id("com.github.gmazzo.buildconfig") version "6.0.9" |
There was a problem hiding this comment.
The BuildConfig Gradle plugin version is hard-coded here. This repo already centralizes plugin versions in gradle/libs.versions.toml (see [plugins] entries like plugin-yml-paper / run-paper), so this should be added to the version catalog and applied via alias(libs.plugins.<...>) (or at least version.ref) to keep plugin versions consistent and easier to bump.
Suggested change
| id("com.github.gmazzo.buildconfig") version "6.0.9" | |
| id("com.github.gmazzo.buildconfig") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.